2.7 Release & Testing - Megathread

ubernaut

@beelee oh ok happy to help if i can

wc_sumpton

Transported units should not be able to disembark in a territory with hostile surface warships present when the attacker chooses to ignore the sea battle using the following option "Sea Battles May Be Ignored".
A submarine which can transport should not be allowed to land units on the same turn that the submarine submerges/retreats from battle.
https://github.com/triplea-game/triplea/issues/13280

Cheers...

WCSumpton created this issue in triplea-game/triplea

open Can do amphibious assault when sea battle is ignored by the attacker with "Sea Battles May Be Ignored" #13280

TheDog

@LaFayette
When downloading a file with 2.7, there is no percentage progress, it jumps from 0 to 100%, this is false as the files are still being downloaded.

https://github.com/triplea-game/triplea/issues/12563
and
https://github.com/triplea-game/triplea/issues/13507

TheDog

Currently the Devs are building their development environment, (Gradle) and getting the Lobby environment (PvP) ready.

This is at the expense of the TripleA engine, currently broke, with its list of outstanding issues. As they are only part timers/hobbists devs and their free time is limited, I suggest players use for now;
This 2.7 pre-release
https://github.com/triplea-game/triplea/releases/tag/2.7.15025

RogerCooper

@thedog If the last reliable version is 15025, we rollback the prerelease.

LaFayette

@TheDog - Could you please make sure that all important issues are labelled with both '2.7' and 'major'. That way they will appear in this list: https://github.com/triplea-game/triplea/issues?q=is%3Aissue state%3Aopen label%3AMajor label%3A2.7

TheDog

@lafayette
Done, a quick refresh for that link above, will look more closely tomorrow at other issues.

LaFayette

Alright, spent a good 4 hours catching up on TripleA today..

2.7 status:

error reporting modules need to be migrated to the support-server (that is why the error-report functionality throws a 404): #14048
need to update the game settings to use the "beta" maps server by default, and remove the old code path that would download & read triplea_maps.yaml
a lot of maps have maps.yaml parsing issues, or are using the "wrong" branch. Need to do three things there:
- A ) server should be forgiving (and even prefer) 'main' as the default branch name
- B ) need to create a report of which maps have problems
- C ) fix the various maps that have problems (at least any problems in 'maps.yaml', there are a lot of missing description files and some other more minor issues here and there)

Otherwise, outstanding are the things on this list: "2.7" & "Major" issue list

While we are beefing that list up, please keep in mind we should only label things that are introduced or made worse by 2.7 as '2.7'.

RogerCooper

@lafayette said in 2.7 Release & Testing - Megathread:

a lot of maps have maps.yaml parsing issues, or are using the "wrong" branch. Need to do three things there:

A ) server should be forgiving (and even prefer) 'main' as the default branch name

B ) need to create a report of which maps have problems

C ) fix the various maps that have problems (at least any problems in 'maps.yaml', there are a lot of missing description files and some other more minor issues here and there)

Do you need some help on the maps? I have done a lot of cleanup already. If you give me examples of the errors I could go in and check them all.

LaFayette

@rogercooper I would love help for it. I'm thinking to update the download maps window to accept the maps with errors. So, instead of seeing a description and an option to download the map, the description would tell you what error the map had. There might need to be an option to "show broken maps" or something.. Overall, I think the download maps windows will be the way to surface these.

In the meantime, most of the YAML errors I think are spaces in the "condensed" format.

For example:
- { map_name: this is map name with spaces, map_path: /my-path }

The map name with spaces breaks YAML, needs to be quoted, eg:

- { map_name: 'this is map name with spaces', map_path: /my-path }

The reasoning is because in the condensed format, YAML can't know where the next token really starts. So, fix #1 is to add quotes.

Fix #2 is to use the expanded format, which is tolerant of spaces, eg:

 - map_name: this is map name with spaces (and is valid!)
   map_path: /my-path

Both formats are sensitive to the leading spaces, the indentation matters. It's pretty high on my list to try and gather a report of the broken maps. No ETA for right now of when that might be available.

RogerCooper

@lafayette If you tried to download one of these broken maps now, would there be an error. Can you give me example of a broken map.

I have already added every finished map to triplea_maps.yaml and downloaded them all without error.

I notice that there some maps which always a need to download such as Alexander 350BC. the mpa.yml file is

map_name: Alexander350
games:
- {game_name: 'Alexander350', file_name: Alexander350.xml}

I notice that says game_name, not map_name. Is that the issue?

TheDog

@rogercooper
Checkout this post from LaFayette
https://forums.triplea-game.org/topic/4056/1888a-steam-steel-official-thread/34?page=2

Note the spaces near the { }

map_name: 1888a_steam_and_steel
games:

{ game_name: "1888A Steam and Steel", file_name: 1888a_steam_and_steel.xml }
or:

map_name: 1888a_steam_and_steel
games:

game_name: 1888A Steam and Steel
file_name: 1888a_steam_and_steel.xml

LaFayette

Did a quick report on invalid maps, just one with invalid YAML that I found:

 Invalid map.yml data found at URI: https://github.com/triplea-maps/1888a_steam_and_steel/blob/master/map.yml?raw=true, error: Invalid yaml format: mapping values are not allowed here

Second, the server needs to be updated to also check for a 'main' branch in the maps. That would fix a few more maps. (We should prefer "main" as our default branch name going forward rather than "master", fwiw. I'm a bit tempted to bulk update all maps to use 'main' as its default branch).

It does seem like there should be quite a few more maps though, even with those fixes applied. I'll need to investigate further to see why/where more maps are not being picked up.

If you tried to download one of these broken maps now, would there be an error.

In those cases the download button would be disabled. So, the map description area would be a place where the server would report the map problems, and no download button.

You may notice, some maps are missing their description.html file, the map download window indicates that file is missing in the description area (but still allows download). So, similar strategy for the maps are fully broken.

The alternative I was thinking was to have a dedicated website page with a big table of each map and its status. That might still be in the cards, but feels cleaner to have that info directly built into the game (and the map tag management I think should be there too rather than in the moderator toolbox).

I notice that there some maps which always a need to download such as Alexander 350BC. the mpa.yml file is

I believe that YAML snippet is fine. The "map_name" is the name of the download, it is the name of the download. After download, the "game name" is the thing that people select as what they want to play, and the "file_name" is a path to the XML file so that the game engine knows where the game data is physically located. FWIW, these values are all now explicit, before the game engine just assumed that the XML had a value that matched the map name, which would match the folder name of the map, etc.. Now none of those need to match, all the "index" information is read from the "map.yml" file. (Of course, to keep compatibility with 2.5 engines, the folder & map names do need to match, with 2.7 the structure and naming is more flexible and less important)

LaFayette

Hmm, interestingly, the current 1888a YAML is valid.
I think those error message I found might have been older.
So, at this juncture, the ball is in my court for server updates and further investigation of why more maps are not showing up.