Question about trenches domination 1914 no mans land

TheDog

@Ramon
I have been working on a new FFA map and realised that SZ PU were not transferring ownership when taken over from their original owner.

There is a lot of work to do to make this happen.
You need a <variableList> for
List of Players, All-Players
List of Sea Zones, All-SZ

and this code

<!-- Change current SZ owner to originalOwner -->
    <attachment foreach="$All-Players$^$All-SZ$" name="conditionAttachment_SZ_@All-Players@_@All-SZ@" attachTo="@All-Players@" javaClass="RulesAttachment" type="player">
		<option name="directOwnershipTerritories" value="@All-SZ@" count="1"/>
    </attachment>
	<attachment foreach="$All-Players$^$All-SZ$" name="triggerAttachment_SZ_@All-Players@_@All-SZ@" attachTo="@All-Players@" javaClass="TriggerAttachment" type="player">
		<option name="conditions" value="conditionAttachment_SZ_@All-Players@_@All-SZ@"/>
		<option name="territories" value="@All-SZ@"/>
		<option name="territoryAttachmentName" value="TerritoryAttachment" count="territoryAttachment"/>
		<option name="territoryProperty" value="originalOwner" count="@All-Players@"/>
		<option name="when" value="before:@All-Players@1EndTurn"/>
	</attachment>

This is not fully tested as I cannot get it to work on an old map 1888A Steam & Steel, but it works for my new map

However, it takes the current SZ owner and makes it the originalOwner, before the EndTurn for each player. Note I have a 1 in front of EndTurn. In your case this can be removed.

This will allow SZ PU to be collected for the owning (now original) player.
Hope it works for you

Ramon

Hi, @TheDog

Thanks a lot for your response!

I made the following changes:

-added the variable list all players/all sz.
-added your code:

However i'm not getting it to work correctly.

The seazones flips to the occupier as intended, but the PUs do not transfer (the original owner does lose the PUs)

for reference, each sea zone is defined like this:

each sz is defined like this:
<territoryOwner territory="Sea Zone 1 Hudson Bay" owner="British"/>

am i missing something, or could this be due to the map being outdated?

Cheers!

Ramon

Hi, @wc_sumpton

Thanks a lot for your response,

The minus signal works perfectly! Thanks!

About the Sea Zones, to clarify:

In this map, we want Sea Zones to have a value of 1 PU. When an opponent captures a Sea Zones, the PU should transfer accordingly, so that the new owner receives 1 production each turn.

Cheers!

Ramon

Hi, @beelee

Thanks a lot about the research and suggestions!

It doesnt seem to work in the usual way, but it could be made to work with triggers (as the dog suggested).

I just wanted to thank you for your help and thinking along with me.

Cheers!

TheDog

@Ramon

So here it is working in the new map.
Check the Territory Tab for
Current Owner=Original Owner

.
In History EndTurn/Resources find Trigger SZ in the relevant round

Ramon

@TheDog

The original owner doesnt change, and i dont see the relevant history like in your map.

is this a problem with the code or with the version?

Maybe a bit of a noob question but does the order where i put the relevant code in the xml matter? That might screw things up?

TheDog

@Ramon

The original owner doesnt change, and i dont see the relevant history like in your map.

If the original owner does not change then the entry in the history list will not appear.

.

is this a problem with the code or with the version?

Very probably not, as it works fine with 11 Rings of Power (the new unpublished map) and does not work with 1888A Steam and Steel. So like you I cant deduce why 1888A is not working 🤯🤯🤯
I have compared xml properties and map properties to no avail.

.

Maybe a bit of a noob question but does the order where i put the relevant code in the xml matter? That might screw things up?

Only that it must be in the Attachment block of code , that is inside
<attachmentList>
</attachmentList>
The order should not matter, but I put Triggers/conditions after other stuff in the attachmentList block.

beelee

@ramon

I think the condition that activates the trigger/condition has to come before the trigger/condition.

Also, other things will still work but depending on where they're listed, will affect how they show up in the purchase window for example.

Support attachments as well but I don't remember the specifics. WC clued me in on it. I need to look it up again.

Ramon

Hi, @TheDog

I noticed the top line:

As i understand it, this should make each sea zone worth 1 PU? That doesn't seem to happen in my map, so im wondering if this might be related to the issue?

I dont know honestly, but thanks for all the help! Let me know if you somehow find a fix!

Another question regarding map creater tool.

I'm editing a map right now (domination 1914 NML).

and following this guide: https://forums.triplea-game.org/topic/3432/a-brief-guide-to-the-map-creator-tools-utilities

Splitting territories in two has worked for me, but creating new territories (islands as example) works differently? I cant get it to work, i assume its different from dividing excisting territories but how does this work?

Same goes for sea zones, does that also work different?

Thank you!

beelee

@Ramon

For a new TTy you will need the correct xml info and then do the centers poly thing as well as drawing the new TTy.

I forget the specifics but I'd pick a TTy and follow it through the xml adding the new name next to it. You can add the connections later but it shouldn't hurt to do it now either.

Once the xml is up to date, follow Elk's guide step by step. @thedog probably more up to date on it than I

If need be, we'll bring in reinforcements if you get stuck

wc_sumpton

@Ramon said:

As i understand it, this should make each sea zone worth 1 PU? That doesn't seem to happen in my map, so im wondering if this might be related to the issue?

This is a condition statement and is checking if player owns a sea zone.

Cheers...