Handling of AI players not meant to be played - Github request.
-
@Frostion The changes are in the latest pre-release now so feel free to test it out. Hopefully we will have a target release date for the next TripleA version soon. I believe you should be able to add the new parameters now and they won't have any impact on the current TripleA release version as it should just ignore them.
-
@redrum said in Handling of AI players not meant to be played - Github request.:
In general, using hacky prefixes or suffixes on strings is something we want to move away from. If there are others please open an issue so we can look to create proper attributes for them.
The fact that islands are handled by looking if their sea zones have names ending exactly in "Sea Zone" might be a good candidate...
https://github.com/triplea-game/triplea/issues/1331 -
@redrum
I think there is something wrong with the feature you made. Things seem to work fine when I use a setup like this:<player name="Slovakia" optional="false" defaultType="AI" isHidden="false"/>In the above case the game starts / has a default setup with the AI controlling Slovakia. I can see this both before gamestart and in the game after startup. The AI controls Slovakia.
But if I in the XML sets isHidden=true, then Slovakia is under human control when it is Slovakias turn. Is this not a flaw?
When looking at the "game history – Game loaded", it seems that all hidden players are automatically set to human, even though they are, in my XML, defaultType=AI.
Map maker of: Star Wars: Galactic War + Star Wars: Tatooine War + Caribbean Trade War + Dragon War + Age of Tribes + Star Trek: Dilithium War + Iron War + Iron War: Europe + Warcraft: War Heroes
-
@Frostion Good catch. I broke this functionality when I added the "default" option to the set all player dropdown
It should now be fixed with https://github.com/triplea-game/triplea/pull/2149. Please test with the latest pre-release.
-
@Frostion Have you gotten a chance to test after I made the fix here?
-
@redrum Yes. I am testing it out in Iron War Europe and it seems to work now. I at least have not seen any problems. I like this feature
And will do an XML update on all my maps when the engine supports it. -
@Frostion Cool. I still need to add it into the POS2 XML as well.
-
Updates to the POS2 XML: https://github.com/triplea-maps/the_pact_of_steel/pull/2
-
@redrum
What ETA would you give on the public release of a TripleA version that handles these features? I was thinking that I could work on updating my maps in advance and just not upload it yet. -
@Frostion Hoping to release in the next week. We are going through some testing and fixing a few bugs that were found. You should be able to make a PR in github or make the changes local and not upload them then wait til its released.
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login