[Open/Need More Info] Guests joining games in progress crash them
-
@RoiEX Well, as I said, this bug appears to be widespread, it happens not always but frequently when, assumingly, users without the map try to join a host, and, once it happens, it seems that the second bug about the corrupted savegame always happens, then, if the hosted player loses connection while the game is frozen.
If I may think of a indirect way of addressing this problem, that way would be logically to invert how the process currently works, for joining games you don't have the map for. Meaning possibly checking for the map's availability (and eventually autodirecting the user to download it from the repository) on your terminal before connecting to the game, or trying to (so that the participants will not even notice if anyone without the map is trying to connect to their game). Also, this way, redirecting to download missing maps in the repository would feel a tad cleaner, if it wouldn't require yourself to crash and lag games first.
Practically, I suppose, the host would need to store the info about what map is being used for that game, like now it keeps the info about what game name is being played, or what is the current round, etc..
I supposed you could even rename the "Name" column in lobby as "Game Name" column, then having a second "Map Name" column next to it, to tell what map is being played there.
-
@Cernel
I created a Pull Request that should at least prevent the stacktrace, on the host and hopefully take a couple of bugs caused by this with it.
https://github.com/triplea-game/triplea/pull/5018
I don't know how much this improves this particular problem, but it should achieve at least a little bitclosed Exception madness #5018
-
@RoiEX Well, anyways, whatever fixes to the program is not really a fix until a lobby compatible with the latest prerelease is out and used by most. That is becoming more and more of a problem, as also there are a number of new features (for new maps) that you cannot use for lobby games. I hope a new lobby in which to use the latest prerelease will be out soon; it has been a while without, by now.
-
Need More Info? It is just something that happens frequently, but not always, when people not having the map try to join games in progress. It happens when both the hoster and the guest are using the current stable. The issue is a very long delay, of several minutes, during which the game is completely frozen for gameplay purposes (you can still scroll the board etc.). If anyone of the participants disconnects while the game is frozen, the game disappears and you get a corrupted connection lost save, that fails to load.
I cannot see what else can be said, on the matter, from the user's side.
-
-
@LaFayette Yes, I posted it in here mostly because I was talking with @epinicion, and in general wanted to see how many people around here were having this issue, as well, and almost no actual lobby users are GitHub readers, I think. But by now I don't think there is really anything more to test out about this issue, so I guess I can see to summarize it in GitHub (maybe soon).
-
@LaFayette I can actually clarify and close this topic at the same time. @Cernel @epinikion and many others have talked about this but it really should be revisited after the next stable is released and all are restricted to the same NEW basic stable. We have many players that enjoy ? using very old game engines to screw things up on purpose is my belief. The other possibility is they just can't be bothered to dl the latest stable. I have witnessed this problem occur both in my own host rarely and in many bots. Thus I do not believe it can be properly addressed until all and bots are the same again. Just my, "Two Cents," worth.
-
@prastle I had a talk with a player that crashed me once, and he gave me the version number corresponding to the current stable, as the TripleA version he was using. So I think that almost verifies this can happen at least also when both players are using the current stable.
-
@Cernel you could be correct Cer but I still think it would be easier to deal with when everything is on the same "page" again since we cannot really pull an error message from it.
-
@prastle Yeah, if the new stable is coming out soon, maybe better waiting for that one, see if it keeps happening or not.
-
@Cernel To clarify everbody is running multiple diff engines with multiple versions of sometimes non updated maps etc etc etc. Thus sadly there is no point of fixing old back compatible stable. All that should be worked on is the new non back compatible stable once a glitch is found. Just mho.
-
@LaFayette said in [Open/Need More Info] Guests joining games in progress crash them:
@Cernel Minimize reproduction steps would be useful. @Cernel can you post a bug on the bug tracker about this?
I'm afraid the only reproduction step is that you play a game in lobby until someone else not having the map tries to join you and causes this issue. As I said, it doesn't appear happening always, as sometimes people joins and leave immediately without me having that issue (I assume when it happens that I see someone joining an leaving in a matter of seconds it would be someone that joined not having the map, tho it might be someone that changed his mind about joining my host very fast).
-
@Cernel Yes I have witnessed it with you. it will be easier when logins are tied to database etc
-
@prastle I was replying to @LaFayette. He asked me to explain how a developer can reproduce this issue, and I don't believe you can do it from the same terminal. So only way I can see is that the developer plays a game in lobby for hours until it happens (maybe).
-
@Cernel I know. But there is no error to be pulled since it crashes before you have the chance to pull anything. Unless We are both missing something?
-
@Cernel to clarify you could not pull anything with 4 of us in your game
-
@prastle As I said, it doesn't automatically crash for me, and I've posted the error here:
https://forums.triplea-game.org/topic/1401/open-need-more-info-guests-joining-games-in-progress-crash-them/6?page=1
I'm getting an error like that all the times it happens.
The crash (with the corrupted connection lost save), with the host completely disappearing, happens only if someone disconnects while the game is frozen. If nobody disconnects, the host goes back working after several minutes of frozeness. -
@Cernel Right which is compatibility issues thus we need to wait until all on same page again. Since it corrupts the save as well they should never have been allowed to join with an incompatibility issue to begin with. Thus back to all having to use the same engine same map to be able to join no?
-
@prastle Yeah, anyways, at this point, I think we can still wait for the new stable and cross fingers this issue won't happen anymore.
-
