How to Delete maps From "triplea-maps" on Git

beelee

Have this map "schultz-european-war" which is misspelled with dashes instead of underscores. Mentioned it multiple times a while back but never got an answer.

Can i delete it or does a dev need to ?

Thanks

Cernel

@beelee I guess the entry in the games (xml) may be fixed, except that Veqryn said maps should never have underscores in their names, as that is what identifies mapskins, but I don't know if this directive is still valid and substantiated (only the developers may know).

Panther

@beelee If you have admin privileges for that repository, you will be able to delete it yourself, in case it is no longer needed.

Look here:
https://help.github.com/en/github/administering-a-repository/deleting-a-repository

RoiEX

What @Panther said, not sure if you have enough rights to do it, but I doubt it.
So you'll probably have to ask @LaFayette or @redrum

LaFayette

FWIW, repositories can also be renamed in their settings menu. If it's just a matter of permissions/rights, please let us know and map admin team can handle it.

These are the rules for finding a map skin based on a map name:

    return mapSkin.startsWith(mapName)
        && mapSkin.toLowerCase().contains("skin")
        && mapSkin.contains("-")
        && !mapSkin.endsWith("properties")

ie: <mapName>-some-variant-skin or
ie: <mapName>-skin-some-variant

Cernel

@LaFayette said in How to Delete maps From "triplea-maps" on Git:

FWIW, repositories can also be renamed in their settings menu. If it's just a matter of permissions/rights, please let us know and map admin team can handle it.

These are the rules for finding a map skin based on a map name:
    return mapSkin.startsWith(mapName)
        && mapSkin.toLowerCase().contains("skin")
        && mapSkin.contains("-")
        && !mapSkin.endsWith("properties")
ie: <mapName>-some-variant-skin or
ie: <mapName>-skin-some-variant

So, starting from a map called schultz-european-war I could make a mapskin called schultz-european-warskin and it would work, I guess.

And how about if the map has both "-" and "skin" already in its name, like if I make a map called dragonsking-wars? Will the original map be seen as a mapskin too?

Anyways, I recall Veqryn didn't want to have any "-" in map's names, but using that character only to start the ending part of mapskins names. I wasn't aware of the "skin" requirement, and I don't like it, especially for the fact that I understand it can be wherever (it would make some more sense it would be required being the name's ending, but in general I don't like that there are two other requisites, beside starting with the map's name).

Cernel

@Cernel As the only conditions for reading a map as a mapskin, I think I would have it to:
start with "mapName",
immediately followed by "-",
immediately followed by any character but "-".

LaFayette

@Cernel said in How to Delete maps From "triplea-maps" on Git:

And how about if the map has both "-" and "skin" already in its name, like if I make a map called dragonsking-wars? Will the original map be seen as a mapskin too?

That seems to be very likely.

Anyways, I recall Veqryn didn't want to have any "-" in map's names, but using that caracter only to start the ending part of mapskins names. I

That would make sense why the 'contains dash' clause is in there. If the map contains no dashes, then the conditions givens are a lot stronger for identifying a map skin. That would almost fix the dragonsking-wars example (ie: dragonsking_wars)

########

FWIW these rules have not changed in quite a lot of time, I'm not sure if I'm a fan of them either.

RoiEX

@Cernel I was just about to ask the same question, I just couldn't come up with a map name containing skin.
Good example

LaFayette

@Cernel good suggestions for fixes; more fundamentally I think the problem is more that there is a magic naming convention at all. Instead of deriving whether something is a map skin or not, it seems more explicit if instead the map skin were to reference the map name directly. EG: we could place a file in the map skin folder "map_skin.properties" and in there, we'd have the name of the map listed, eg:

map=dragonsking-wars

If the map_skin.properties file is present, then we know we have a map-skin, otherwise it's a map.

Cernel

@LaFayette No: I like at least the fact that mapskins have to start with the name of the original.

LaFayette

@Cernel That would probably be a good convention, relying on it likely will continue to run into other magic naming problems. Since map names are relatively arbitrary, the names being associated by prefix only is a fundamental weakness of that design. This feels similar to the original problem stated in this forum thread, where naming conventions have to line up just so, it's an unnecessary source for errors.

LaFayette

@beelee you should be able to rename it, let me know if not: https://github.com/triplea-maps/schultz-european-war/settings

Screenshot from 2019-11-04 10-31-22.png

beelee

@LaFayette Thanks for the replies everyone. Yea what happened was is a couple years ago I added Schultz's map with the dashes then added another one with the underscores when I saw dashes weren't supposed to be used. I couldn't delete the first one and asked someone to do it but... so anyway, there are two right now.

I wasn't real familiar with git then and not a whole lot better now : ) although i did learn about the rename thing today : ) so I thought I couldn't delete the one with dashes and turns out I can't.

Yea Panther was correct as I've deleted repos before but "settings" doesn't show up for deleting the schultz map. So yea someone else will need to do it.

LaFayette

@beelee Ah, I suppose you need more than 'write' permissions. That repo (with dashes) is now deleted

beelee

@LaFayette