NodeBB 1.17 and later breaks PBF compatibility

RoiEX

If you have like 5 Minutes, please feel free to review it, it's a rather small change. Not really clean but it should work for now

redrum

@roiex Yeah, looks good. I merged it. Do you know if we are close to pushing out a release? Otherwise, we should probably consider putting that fix into 2.5 and pushing it out.

Panther

@roiex @redrum

I just want to bring this issue back to attention. It seems like we get no answer to the question how close a 2.6 release actually is.

This seems to indicate that it might be useful to push an updated 2.5 stable.

LaFayette

@panther This is the 2.6 project: https://github.com/triplea-game/triplea/projects/25

Volunteers to help come up with a list of any other items that need to be fixed would be really welcome (https://forums.triplea-game.org/topic/2999/2-6-release-getting-close-need-volunteers-to-help-beta-test-2-6/3)

Panther

@roiex

Unfortunately this fix doesn't work as expected.
I have just verified
https://github.com/triplea-game/triplea/issues/10117

and can confirm it with 2.6.571.

Anyone else tested PBF on A&A .org using a current prerelease?

cc: @redrum

redrum

@panther I made another fix for the new nodeBB version and it was just merged: https://github.com/triplea-game/triplea/pull/10206

I tested myself and was able to post to A&A.org with the latest pre-release. I would appreciate if a few others can test it to verify then we can look to release a patch version with the fixes.

ubernaut

@redrum what exactly would like me to test? sorry, i can be slow sometimes

AndrewAAGamer

Sounds like this is almost resolved! That is great because while able to do this manually it is much more of a pain than being able to push a single button to post. Thank you in advance for getting this fixed!

Panther

@ubernaut said in NodeBB 1.17 and later breaks PBF compatibility:

@redrum what exactly would like me to test? sorry, i can be slow sometimes

The test is about using the current TripleA pre-release with PBF on axisandallies.org/forums.

Panther

@redrum said in NodeBB 1.17 and later breaks PBF compatibility:

@panther I made another fix for the new nodeBB version and it was just merged: https://github.com/triplea-game/triplea/pull/10206

I tested myself and was able to post to A&A.org with the latest pre-release. I would appreciate if a few others can test it to verify then we can look to release a patch version with the fixes.

Very cool! Thanks a lot. I have tested prerelease 2.6.616 on axisandallies.org/forums successfully. Now it works as expected.

Yes a patch version would be very welcome!

Panther

@nothingtoseehere said in Google mail with TripleA issues (was: New Play By Forum Game):

@panther Does this mean, that PBF is possible again with the newest pre-release? If so is there still an issue with loading maps on pre-release versions of the client?

Yes, PBF is possible with the current pre-release, indeed.
In order to download maps you need to alter a setting in the Engine Preferences.
In the tab "Testing" switch "Lobby URl Override" to "Pre-Release".

However @redrum suggested a patch version above - that might at the moment be preferable rather than a pre-release.

Nothingtoseehere

@panther, @redrum Did I understand this correctly, that the PBF fix is currently available as part of the latest pre-releases and that a patch for 2.5 stable is being planned but not released yet?

redrum

@nothingtoseehere Correct.