Can we fix TWW?
-
@nothingtoseehere said in Can we fix TWW?:
@zlefin @Cernel:
@zlefin said in Can we fix TWW?:I don't know what the status of the stuff on the todo list or partly done 3.0.0.7 was (ie the stuff listed in the above thread)
- They probably should be able to iirc; I'm not that sure as I never used the options that brought neutrals into the war. Generally speaking though, CE should gain amphib assault at the same time regular infantry do. I just don't know when that is for neutral.
I just looked at the map in GitHub. There is a 2-year-old fix in the Pull Requests of the map it's called 3.0.0.7.
Could we maybe combine your fixes and the old ones and then commit it as 3.0.0.8?Wow! That's exactly what I was talking about.
@redrum Why do you have that PR open since almost 3 years? By the way, I believe you forgot to update the version number within the file there: I think you should do that before merging.
-
@nothingtoseehere said in Can we fix TWW?:
@zlefin @Cernel:
@zlefin said in Can we fix TWW?:I don't know what the status of the stuff on the todo list or partly done 3.0.0.7 was (ie the stuff listed in the above thread)
- They probably should be able to iirc; I'm not that sure as I never used the options that brought neutrals into the war. Generally speaking though, CE should gain amphib assault at the same time regular infantry do. I just don't know when that is for neutral.
I just looked at the map in GitHub. There is a 2-year-old fix in the Pull Requests of the map it's called 3.0.0.7.
Could we maybe combine your fixes and the old ones and then commit it as 3.0.0.8?To answer your question, I didn't make that pending PR, so I don't care about it and it means nothing to me. If increasing the latest digit, I would push it as 3.0.0.7 just like that PR doesn't even exist unless said PR is merged before I make mine.
If that PR conflicts in any way with mine, I assume it is someone else's responsibility not to merge it too before or after merging mine.
By the way, unless I'm overlooking something, that PR doesn't even change the version number, so I guess merging it would leave the game at 3.0.0.6 (which I suppose is a mistake).
Generally speaking, I would suggest that PR do not remain pending for about 3 years: I think any PR on any map should be merged or closed within 7 days, actually. Issues, instead, can remain open for 3 years or more, of course.
-
@ubernaut said in Can we fix TWW?:
@cernel that's awesome i'm not really sure how that all works who all can approve merge? i am a map admin over on github so maybe i can? willing to take any flak if either of them protest the patch but i can't imagine why they would
@ubernaut Can you please close (without merging it) this PR?
https://github.com/triplea-maps/total_world_war/pull/21This PR is almost 3 years old and it fails to update the version number (thus creating a different 3.0.0.6 game). I believe it should better be closed so that anyone may interface the map (for changing it) without any pending PR in the way.
-
@cernel said in Can we fix TWW?:
By the way, unless I'm overlooking something, that PR doesn't even change the version number, so I guess merging it would leave the game at 3.0.0.6 (which I suppose is a mistake).
yes, my understanding is that the current version was meant to be 3.0.0.8 but @redrum forgot to update the version number when he did it
@ubernaut Can you please close (without merging it) this PR?
https://github.com/triplea-maps/total_world_war/pull/21done, i think
-
How's it coming along?
-
@sveaguldfisk As far as I'm corncerned, I'll get back to this once I'm done testing and discussing some things about the program itself (related to units starting in hostile zones).
-
@cernel not trying to rush you
@Nothingtoseehere and i were planning to have a game of TWW we were waiting on the fix so we could help test. should we wait you figure or might it be a while? -
@ubernaut Maybe wait a few days and see if I get it done. Not promising anything though.
I've already fixed the bug at this topic (and the one at the recently closed PR), but I was thinking to fix all reported ones so to get a stable version which would be just waiting for someone to rewrite the rule-book.
-
@cernel: Is there a PR of your current version on GitHub or do you only keep it locally?
-
@nothingtoseehere As you can see, there is nothing of this from me on GitHub. I was just talking about what I have in my computer.
-
-
@ubernaut I'm not waiting for that: it's just that things came up and I really cannot say when I will go back to this. My plan was to add the rules-relevant parts of what explained at the first post of the map's official thread.
-
@ubernaut said in Can we fix TWW?:
@cernel not trying to rush you
@Nothingtoseehere and i were planning to have a game of TWW we were waiting on the fix so we could help test. should we wait you figure or might it be a while?I'm having a situation it's probably better you start your game as it is very unlikely it will be a matter of days at this point. Sorry.
-
@cernel been pretty busy lately anyway even if we are talking weeks i'd prolly wait myself
-
@cernel yeah that makes sense happy to help with that part
-
@Cernel: Since I want to start my next game soon, I was curious, if you want to share the map in its current state, so we can test it by playing it.
-
If someone has a fully patched XML file that fixes this issue, please post it as an attachment. That would be a good building block that others can work from.
After we have an updated XML file that is validated to fix this issue, then we just need to upload it (which should take 5-20 minutes to do): https://docs.github.com/en/repositories/working-with-files/managing-files/editing-files#editing-files-in-another-users-repository
-
Did a bug fix for TWW.
bugs fixed:
carriers having 2hp before that tech is researched.
repairs for minor nation entrench/fortifications
alpine infantry placement locations in Eastern Central US
Liberations not always giving proper engineer+factory
advanced mechanization giving +2 att instead of +1 att5 bugs fixed; the other issues listed in the thread were mostly could not reproduce; one of them used quite old versions of the engine and map. the sweden capturing an RC one just doesn't matter enough to fix, not even sure it's a bug anyways.
My testing indicates the fixes work, but testing has not been extensive at all, only rudimentary.corrected the name of the file and reloaded it, since I don't know of another way to fix it. below is the one with the fixed name.
-
-
@zlefin also is this downloadable haven't played a game in forever would be happy to test
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login