2.7 Release & Testing - Megathread

ubernaut

@beelee oh ok happy to help if i can

wc_sumpton

Transported units should not be able to disembark in a territory with hostile surface warships present when the attacker chooses to ignore the sea battle using the following option "Sea Battles May Be Ignored".
A submarine which can transport should not be allowed to land units on the same turn that the submarine submerges/retreats from battle.
https://github.com/triplea-game/triplea/issues/13280

Cheers...

TheDog

@LaFayette
When downloading a file with 2.7, there is no percentage progress, it jumps from 0 to 100%, this is false as the files are still being downloaded.

https://github.com/triplea-game/triplea/issues/12563
and
https://github.com/triplea-game/triplea/issues/13507

TheDog

Currently the Devs are building their development environment, (Gradle) and getting the Lobby environment (PvP) ready.

This is at the expense of the TripleA engine, currently broke, with its list of outstanding issues. As they are only part timers/hobbists devs and their free time is limited, I suggest players use for now;
This 2.7 pre-release
https://github.com/triplea-game/triplea/releases/tag/2.7.15025

RogerCooper

@thedog If the last reliable version is 15025, we rollback the prerelease.

LaFayette

@TheDog - Could you please make sure that all important issues are labelled with both '2.7' and 'major'. That way they will appear in this list: https://github.com/triplea-game/triplea/issues?q=is%3Aissue state%3Aopen label%3AMajor label%3A2.7

TheDog

@lafayette
Done, a quick refresh for that link above, will look more closely tomorrow at other issues.

LaFayette

Alright, spent a good 4 hours catching up on TripleA today..

2.7 status:

error reporting modules need to be migrated to the support-server (that is why the error-report functionality throws a 404): #14048
need to update the game settings to use the "beta" maps server by default, and remove the old code path that would download & read triplea_maps.yaml
a lot of maps have maps.yaml parsing issues, or are using the "wrong" branch. Need to do three things there:
- A ) server should be forgiving (and even prefer) 'main' as the default branch name
- B ) need to create a report of which maps have problems
- C ) fix the various maps that have problems (at least any problems in 'maps.yaml', there are a lot of missing description files and some other more minor issues here and there)

Otherwise, outstanding are the things on this list: "2.7" & "Major" issue list

While we are beefing that list up, please keep in mind we should only label things that are introduced or made worse by 2.7 as '2.7'.

RogerCooper

@lafayette said in 2.7 Release & Testing - Megathread:

a lot of maps have maps.yaml parsing issues, or are using the "wrong" branch. Need to do three things there:

A ) server should be forgiving (and even prefer) 'main' as the default branch name

B ) need to create a report of which maps have problems

C ) fix the various maps that have problems (at least any problems in 'maps.yaml', there are a lot of missing description files and some other more minor issues here and there)

Do you need some help on the maps? I have done a lot of cleanup already. If you give me examples of the errors I could go in and check them all.

LaFayette

@rogercooper I would love help for it. I'm thinking to update the download maps window to accept the maps with errors. So, instead of seeing a description and an option to download the map, the description would tell you what error the map had. There might need to be an option to "show broken maps" or something.. Overall, I think the download maps windows will be the way to surface these.

In the meantime, most of the YAML errors I think are spaces in the "condensed" format.

For example:
- { map_name: this is map name with spaces, map_path: /my-path }

The map name with spaces breaks YAML, needs to be quoted, eg:

- { map_name: 'this is map name with spaces', map_path: /my-path }

The reasoning is because in the condensed format, YAML can't know where the next token really starts. So, fix #1 is to add quotes.

Fix #2 is to use the expanded format, which is tolerant of spaces, eg:

 - map_name: this is map name with spaces (and is valid!)
   map_path: /my-path

Both formats are sensitive to the leading spaces, the indentation matters. It's pretty high on my list to try and gather a report of the broken maps. No ETA for right now of when that might be available.