Expand UserActionAttachment & PoliticalActionAttachment To All Resources
-
Do we have to replace "costPU" in existing maps to launch error free?
-
@All
I have removed all instances of costPUs in my maps at GitHub. I have not given the maps a new version number or edited the yaml file, because no alterations have been made to the game besides this minor edit.Is it necessary for me to give new version numbers and edit the yaml? Can new downloads of the maps (with this edit) play with old downloads without conflicts/errors?
-
@general_zod That may happen after I convert all, if Civil War stops swamping me with its endless issues.
-
@frostion Well, I can answer you about this.
Since the costResources didn't exist before, people using engine not having it yet will get a whole bunch of errors and will be unable to now play your maps.
Normally, when adding a new feature, at the next stable release at least, you would increase the triplea version and, then, you would just need to set that version in the triplea minimumVersion of the xml, to avoid people with old engines getting errors, but we are stucked at 1.9.0.0 since a while... -
@cernel Yeah, by the way, why are we stuck at this version?
-
I see you have already updated "Pact of Steel 2" yourself. So that could have gone out of my list.
However, I looked at your changes and saw that now Americans would be able to give British 6 PUs at no cost to themselves, while it used to cost 10 PUs.
This pull request should restore the functionality of having the aforementioned action costing 10 PUs for Americans:
https://github.com/triplea-maps/the_pact_of_steel/pull/17
In doing it, I went ahead adding the cost info in the button description.
I've also put back three commented out not default functionalities (doesn't matter, but I prefer to keep the intended code).
@redrum to merge
Theorically, people that downloaded this map meanwhile should be told to redownload it, but I'll leave it up to the admins to decide if to update the download number (I made no pull for the yaml). -
domination_1914_blood_and_steel has a few instances in actionstext that are not present in the actual game. For example:
Austrians_Aid.BUTTON=Give aid to Austrians Austrians_Aid.DESCRIPTION=Give economic and military aid to Austrians Austrians_Aid.NOTIFICATION_SUCCESS=You have given 20 PUs to Austrians. Austrians_Aid.OTHER_NOTIFICATION_SUCCESS=The Germans have given aid to Austrians. Austrians gains 5 PUs. Austrians_Aid.NOTIFICATION_FAILURE=NONE Austrians_Aid.OTHER_NOTIFICATION_FAILURE=NONEBut there are no "Austrians_Aid" occurrences in the xml.
Just saying that is such cases I will determine the PUs count based on the actionstext descriptions.
I recall that @Schulz (under a previous username) was the map owner (and requested removal). -
I've the changes done for all except civil_war, but I'm waiting the pending pull request on civil_war to be closed. I would prefer to push all of them together and reference them in a GitHub issue.
-
-
Looking to update this further so the resource icons are displayed instead of the text. Example:
