Expand UserActionAttachment & PoliticalActionAttachment To All Resources

[redrum]

@cernel POS2 XML should be updated through the latest changes now.

[Frostion]

@redrum @Cernel
I have been offline a lot lately because of real life work. And for some reason I recently have not gotten any info-mail from TripleA forum.

I am totally fine with cost PUs being changed to cost resources, and will update my maps, if the Pact of Steel 2 xml is updated and I can see what to do.

Is it final how those buttons and cost/outcome info will look like? I would prefer if the engine maintained some kind of consistency across maps, like if cost was always displayed the same way somehow. The political action outcome is another matter as there are so many possibilities and probably can't be automatically generated.

@Cernel I can't see why I would want to have two XMLs in the Iron War map. It must be a mistake. I am not home and can't see what and where this second xml is located. But will check it out asap.

[redrum]

@frostion POS2 XML is updated with an example and the first post of this thread has an example and a screenshot. I'm open to adjusting how it displays if folks have better ideas.

[Cernel]

@redrum What I understood we already potentially agree is to remove that entirely, after I've updated all the properties to tell the cost themselves.

What I plan to do is just adding the thing like it looks now in all except I'm thinking for Civil War to change so that like, regarding what the user sees:

[25 PU] Finance Debt
would become
Pay $25 Debt Installment.

and:
[25 PU] PRIORITY: Debt Backpayment
would become
PRORITY: Pay $25 Debt Arrear.

Really, that is not done the right way. Instead of having a big "PRIORITY" mark on it, it could have been just coded that first you get only the arrear, and then you get the regular instalment after you clicked on (paid for) the arrear, since you don't want to pay the regular but not the one that would default you, obviously (thus the priority warning), but I don't plan to do that.

I personally don't like and don't agree with using "$" (vel similia) to mean "PUs", unless the scale makes sense (1 PU is actually representing 1 $); just going that way for coherence with the rest, as is.

There are no reasons whatsoever to display that cost or anything mandatory in the buttons. The mapmakers can customize it as they want, also exactly like it looks now (possibly better).

At most, we can think about some sort of tooltip that tells the various things (chance success, number retry allowed, cost resources...), but I'm not advising it.

[General_Zod]

@cernel

A tool tip for the user/political actions buttons sounds like a potentially very useful feature. Since the majority of these actions will likely not be intuitively self explanatory actions, a space saving informatory description sounds great. Perhaps in a .properties file.

[General_Zod]

@redrum

Do we have to replace "costPU" in existing maps to launch error free?

[Frostion]

@All
I have removed all instances of costPUs in my maps at GitHub. I have not given the maps a new version number or edited the yaml file, because no alterations have been made to the game besides this minor edit.

Is it necessary for me to give new version numbers and edit the yaml? Can new downloads of the maps (with this edit) play with old downloads without conflicts/errors?

[Cernel]

@general_zod That may happen after I convert all, if Civil War stops swamping me with its endless issues.

[Cernel]

@frostion Well, I can answer you about this.
Since the costResources didn't exist before, people using engine not having it yet will get a whole bunch of errors and will be unable to now play your maps.
Normally, when adding a new feature, at the next stable release at least, you would increase the triplea version and, then, you would just need to set that version in the triplea minimumVersion of the xml, to avoid people with old engines getting errors, but we are stucked at 1.9.0.0 since a while...

[alkexr]

@cernel Yeah, by the way, why are we stuck at this version?

[Cernel]

I see you have already updated "Pact of Steel 2" yourself. So that could have gone out of my list.
However, I looked at your changes and saw that now Americans would be able to give British 6 PUs at no cost to themselves, while it used to cost 10 PUs.
This pull request should restore the functionality of having the aforementioned action costing 10 PUs for Americans:
https://github.com/triplea-maps/the_pact_of_steel/pull/17
In doing it, I went ahead adding the cost info in the button description.
I've also put back three commented out not default functionalities (doesn't matter, but I prefer to keep the intended code).
@redrum to merge
Theorically, people that downloaded this map meanwhile should be told to redownload it, but I'll leave it up to the admins to decide if to update the download number (I made no pull for the yaml).

[Cernel]

domination_1914_blood_and_steel has a few instances in actionstext that are not present in the actual game. For example:

Austrians_Aid.BUTTON=Give aid to Austrians Austrians_Aid.DESCRIPTION=Give economic and military aid to Austrians Austrians_Aid.NOTIFICATION_SUCCESS=You have given 20 PUs to Austrians. Austrians_Aid.OTHER_NOTIFICATION_SUCCESS=The Germans have given aid to Austrians. Austrians gains 5 PUs. Austrians_Aid.NOTIFICATION_FAILURE=NONE Austrians_Aid.OTHER_NOTIFICATION_FAILURE=NONE

But there are no "Austrians_Aid" occurrences in the xml.
Just saying that is such cases I will determine the PUs count based on the actionstext descriptions.
I recall that @Schulz (under a previous username) was the map owner (and requested removal).

[Cernel]

I've the changes done for all except civil_war, but I'm waiting the pending pull request on civil_war to be closed. I would prefer to push all of them together and reference them in a GitHub issue.

[Cernel]

https://github.com/triplea-game/triplea/issues/3475

[redrum]

Looking to update this further so the resource icons are displayed instead of the text. Example: