Strategic Bombing Clarification

RogerCooper

What is the difference between "SBR Affects Unit Production" & "Damage From Bombing Done To Units Instead Of Territories"?

Hepps

Here is the description... from POS

	1. 	First use is used only with ww2v3 factory damage rules ("SBR Affects Unit Production"), which have damage done to a Territory, not to a Unit.
				This decides the damage the territory starts at.  If unitProduction is less than production, then the territory starts damaged.  If they are equal, then the territory is not damaged.
		2. 	Second use is used with newer maps which are using the new damage rules ("Damage From Bombing Done To Units Instead Of Territories"), which have damage done to an individual Unit instead of a Territory.
				When used with these rules, "unitProduction" lets you set the unit production potential of a territory, separate from the production. This means a territory with unitProduction = 2 will be able to produce 2 units there, regardless of if production is 0 or 20.
				The damage potential of these units will normally be 2x the unitProduction, but this can be set individually by creative use of maxDamage and canProduceXUnits.
			Must be placed UNDER 'production' in the xml, because 'production' automatically sets 'unitProduction' to be equal otherwise.

Cernel

@rogercooper In 1.8.0.9 they were the same. Many years ago they were different (but that's old story). Currently, I'm not sure.

Cernel

@hepps said in Strategic Bombing Clarification:

Here is the description... from POS

  1. 	First use is used only with ww2v3 factory damage rules ("SBR Affects Unit Production"), which have damage done to a Territory, not to a Unit.
  			This decides the damage the territory starts at.  If unitProduction is less than production, then the territory starts damaged.  If they are equal, then the territory is not damaged.
  	2. 	Second use is used with newer maps which are using the new damage rules ("Damage From Bombing Done To Units Instead Of Territories"), which have damage done to an individual Unit instead of a Territory.
  			When used with these rules, "unitProduction" lets you set the unit production potential of a territory, separate from the production. This means a territory with unitProduction = 2 will be able to produce 2 units there, regardless of if production is 0 or 20.
  			The damage potential of these units will normally be 2x the unitProduction, but this can be set individually by creative use of maxDamage and canProduceXUnits.
  		Must be placed UNDER 'production' in the xml, because 'production' automatically sets 'unitProduction' to be equal otherwise.

I'm thinking that description is obsolete, and at least in 1.8.0.9 "SBR Affects Unit Production" was damaging the factory, not the territory, just like "Damage From Bombing Done To Units Instead Of Territories", but I'm not absolutely sure and I would need veqryn (if he even remembers) to confirm if that explanation was not fully updated.

RogerCooper

@cernel I am not sure that "SBR Affects Unit Production" is still working. I had a scenario where I had copied the code and I recently noticed that the Strategic Bombing was not working properly. When I added "Damage From Bombing Done To Units Instead Of Territories", it worked fine.

ssoloff

@rogercooper "SBR Affects Unit Production" appears to have been removed in 1.9.0.0.2772 (2016-08-17) via https://github.com/triplea-game/triplea/pull/1077. Perhaps @LaFayette can provide context if you need it.

DanVanAtta created this issue in triplea-game/triplea

closed XML Property Updates from #1033 + XML GameProperty cleanup #1077

RogerCooper

@ssoloff The xml options browser does not show this as deprecated.

Cernel

@rogercooper If they have been removed, they are not deprecated.

I asked about this in GitHub, actually, but nobody answered me, and the issue was closed:
https://github.com/triplea-game/triplea/issues/3462

But, actually, if it's removed, I guess it would belong to this other one:
https://github.com/triplea-game/triplea/issues/3463

So that is closed for me. But good to know anyways; maybe it should be documented somewhere (I don't know).

Cernelius created this issue in triplea-game/triplea

closed Document Deprecated Items #3462

Cernelius created this issue in triplea-game/triplea

closed Document Discontinued Items #3463

Cernel

@ssoloff If it was in 1.9.0.0.2772, it should have been documented here:
https://github.com/triplea-game/triplea/wiki/Upgrade-Maps-Information

I guess you'll have to reupgrade all your maps having this property again @RogerCooper.