Total World War: December 1941 3.0.0.6

ubernaut

@ubernaut just noticed another odd thing Screen Shot 2019-05-10 at 4.07.25 PM.png

redrum

@ubernaut you might want to delete and redownload the map as that seems really strange.

Shonn

Question - maybe related to a bug.

Vichy France builds Barracks in Algeria.
Then Allies land in Marocco. Algeria turns German.
Germany cannot place anymore INFs or other new units in Algeria, not acknowledging the presence of the Barracks.

Is that intended or a bug?

redrum

@Shonn The barracks should change to be controlled by Germany so that they can build units there instead of Vichy. If that didn't happen then if you can upload the save, I'll take a look.

ubernaut

@redrum fixed the dice thing. the notifications are not working, also in the 2.8 variation. pretty sure this was working prior to when i tried to start a forum game which was also the first time i started a game under this version. when i was using saved games with this version that were 3.0.0.2 it was still working.

redrum

@ubernaut Yeah, I recently updated all the notification image paths to not reference sourceforge. For some reason, it appears the path is incorrect for at least Macs. It tries to reference the notification images in the map zip like this:

<img src="/doc/images/thailand.png"/>

@RoiEX Do you have a mac or maybe even a linux box and could test if you can see these notifications in TWW?

ubernaut

@redrum thanks for looking into it. also for whatever reason that dice bug came back too . i will try to see if it goes away next time i quit.

Screen Shot 2019-05-12 at 11.07.17 AM.png

redrum

@ubernaut Actually can you test something for me. Can you edit the notifications.properties file in the TWW/map folder and change this line:

Startgermany=<body><img src="/doc/images/startgermany.png"/></body>

to

Startgermany=<body><img src="startgermany.png"/></body>

Then launch a new TWW game and see if the initial germany notification appears properly.

ubernaut

@redrum nope i also tried "/startgermany.png"

RoiEX

@redrum I have access to a mac on Tuesday, what exactly do you want me to check?
I haven't followed the whole conversation

redrum

@RoiEX I updated TWW notifications.properties to reference local images from the map zip rather than sourceforge links: https://github.com/triplea-maps/total_world_war/commit/5984d1cec952bfc7e07fa9dde36af188a4d17a63

But it appears the images aren't showing for @ubernaut who has a mac but works fine for me on a windows machine. Trying to isolate if its a mac issue with the image path or a specific issue for him.

The notifications appear as popups once you start a new TWW game and click past the bid phase.

@ubernaut Can you make sure you don't have multiple TWW maps in your maps folder. Or clear out your maps folder and redownload.

ubernaut

@redrum yeah it was clear just the one.

RoiEX

@redrum I dug a little bit into the code and haven't found a real reason, but a couple of places where the system could be tripping up.

https://github.com/triplea-game/triplea/blob/77cb757693a0a1afae028ed05b653376e23c9933/game-core/src/main/java/games/strategy/triplea/attachments/TriggerAttachment.java#L1478-L1486

This code seems to strip out html tags out of notification properties if the string is too long. Shouldn't be the case here, but still weird.

Just before the HTML is parsed and interpreted to be shown to the user the engine "localizes" the external HTML resources:

https://github.com/triplea-game/triplea/blob/d21ee00a40ae6faf8cf52fbb24554d8de0a3bbd8/game-core/src/main/java/org/triplea/util/LocalizeHtml.java#L71-L72

This means 2 Things:

It's not necessary to have the /doc/images/ prefix in the src attribute because everything except for the basename will be stripped away
Removing the sourceforge part of the URL in the src attribute has 0% effect because everything except for the basename will be stripped away

Also if the engine tries to search for a resource that doesn't exist, an exception will be logged and an error window should pop up.
So it's clearly not the change on your end, at least for latest master. I have fiddled around with the LocalizeHtml class in the past, so maybe on the latest stable there is actually a difference, but probably not for TWW compatible versions.

So because there is no exception this probably means that the tag gets removed at some point for some reason we don't know, but I think it's fairly unlikely the issue is cause by the OS at this point.

redrum

@RoiEX Yeah, I had noticed the /doc/images/ wasn't needed and that's why I asked to try without that as well. I'm going to remove those prefixes from the map.

Only thing I could think of is a duplicate map or something causing image loading issues.

RoiEX

@redrum
What we haven't tested yet:
@ubernaut Can you replace the whole <body><img src="/doc/images/thailand.png"/></body> with <body>Display Test</body> or just Display Test and try again?

If everything stays the same then the engine wouldn't seem like it's using the real property file.

ubernaut

@RoiEX the first thing did nothing the second thing seemed at first to do nothing (same blank dialog) but then a second dialog came up with the test message.

RoiEX

I'm even more confused now
But at least something is happening, not sure what to do with this knowledge though.

Shonn

@redrum For that save I think it's easier if I pass you through the lobby! But the situation of the non working converted barracks repeated in a few games. And I think it's easily duplicable as well in any game.

@Hepps Adding, I feel Armour can use at least also a +1 attack through some technology - and eventually also added defence to have a final base of 7 / 6 / 2 (Dare say diluted in 3 different techs - including improved armour giving +1 defence). Currently they're easy to hard counter with AT (that can gain through techs). I believe Armour should upgrade as well through tech to keep in tune a line of armour piercing vs armour technology race (if that ever happens). To be a 6 costing unit they have lots of penalties in many terrain ontop of having a direct hard counter if they're spammed.

ubernaut

the dice thing seems to be random.

RoiEX

@redrum Notifications seem to work fine for me on a mac