2.3 is Released!

SilverBullet

@Raziridium hmm, i will try that next time i come across it, thanks.

Schulz

Still I can't open maps in 2.4 unfortunately.

LaFayette

@Schulz would you mind providing more details on what you are seeing? Are you getting any kind of error message?

Schulz

Trevan

@Schulz can you click the "Report to TripleA" button and add a message in it linking back to this forum post?

Panther

@Schulz

Your screenshot indicates that you did not select any map. So there is nothing to open.

Starting from that screen:

What happens when you klick ok?

The message should disappear then.

After that you can neither klick "Select Map" nor "Download Maps" ?
Please try that and report what happens.

Schulz

After clicking, it disappears but when trying to click "select map" it appears again.

"Download Maps" works. Load games also work too.

https://github.com/triplea-game/triplea/issues/8017

LaFayette

The error report is really useful. Did you last play a custom map @Schulz ?

My guess is there is a XML file in that last map that is now being loaded. The game engine will now load any XML file in a map bundle, not just the XMLs in 'games'.

I suspect a fix for this problem could be done pretty quickly, stay tuned. In the meantime, if you're able to select a different map, you might not see the error. Please let me know if you see the same error for any map that you select.

Trevan

@Schulz what happens if you load a saved game, play it, quit triplea, and then re-open triplea? Do you get the same error? Do you have saved games from different maps, can you try a few of the saved games?

Schulz

I don't remember which map I was playing.

@Trevan yes, I get the same error with that way. I had save games from diferent maps, they all work fine.

Trevan

@Schulz The error looks like it is occurring because the last map you played isn't liked by 2.3 or 2.4. That's why I'm asking you to load a saved game, play it, and then close triplea completely and reopen it. Each time you load a saved game, it changes the last map you played. And when you exit triplea and then reopen triplea, it should try and load the map from the saved game you just played.

You said that you have several saved games from different maps. Did you try each one of them (load the game, play it, exit triplea, open triplea)? Did they all cause the error? What are the maps of the saved games that cause the error when you open triplea?

And once you've found a map that "fixes" the error, then you should be able to load maps without any problem.

Schulz

All load games work.

Trevan

@Schulz said in 2.3 is Released!:

All load games work.

I'm not asking if the load games work. I'm asking you to load the game, then quit triplea and then restart triplea. Does that fix the problem?

Schulz

It didn't fix the problem.

LaFayette

Spent the last 4 hours investigating issues loading save games and am turning up not a lot.

I'm seeing two issues:

Stack Overflow on bot loading save
Save game hangs

(1) looks to be 'fixable' by setting XSS on the bots to match the value we have for the headed game running

For (2), I've narrowed the hang down to the client side on these lines in GameDataManager.java:

  public static GameData loadGame(final InputStream is) throws IOException {
    checkNotNull(is);

    final ObjectInputStream input = new ObjectInputStream(new GZIPInputStream(is));
    try {
      final Object version = input.readObject();

I launched a bot in 2.2 with a headed client on 2.2 and the hang happened. Sometimes the hang did not happen and I was not able to deterministically determine what that was.

I'm attaching a save-game I was sent that gets a hang when you launch the game via save-game on bots.

aktuell.tsvg

Trevan

@Schulz said in 2.3 is Released!:

It didn't fix the problem.

Does it fix the exception showing in the UI? I've manually replicated the error by changing the code to throw an exception at the same point but I can still see select a new map to play. So this error appears to not be related to the map selection issue. Do you get a different error when you click on the "Select Map" button? What maps do you have downloaded? Can you try deleting all of them (or moving them to a different directory) and then downloading one again and see if that map can be selected?

LaFayette

@Schulz , @Trevan , this update should help: https://github.com/triplea-game/triplea/pull/8031

It looks like a map is dying in an unexpected way during parse and that is killing the whole game. Deleting all maps should be a very blunt force way of fixing that. If you download the very latest @Schulz , you should get an error message telling which XML is generating a problem and then you should be able to continue to select a different map. As-is, the validation during parse is going uncaught and I would imagine is killing the whole client.

Schulz

Even temporarily removing maps from "downloadedMaps" folder didn't help. Its all the same error message. I've downloaded most of maps from repository. I have never experiences similar thing before.

LaFayette

@Schulz , would you mind installing the very latest and see if you get any different behavior: https://github.com/triplea-game/triplea/releases/tag/2.5.22237

Schulz

The same issue is still present unfortunately.