2.6 Testing (Report 2.6 problems here)

beelee

@lafayette I am uploading "map" that is inside the game/map folder in downloaded maps.

Screenshot from 2022-10-18 18-36-15.png

LaFayette

@beelee If you have that map installed, after you launch a 2.6 it should automatically create a game notes file for you (if it does not already exist).

Here is an example:

map/games/
map/games/great_war.xml
map/games/great_war.notes.html

The game notes file should have the same name as the map XML scenario, but instead of ending with 'xml', it should end with 'notes.html'

The generation of this file is one-time and happens at TripleA startup. Hence any further updates to the 'xml' file will not be reflected in the 'notes.html' file.

Also of note, the 'notes.html' file is read every time game notes are opened (this was not the case for XML game notes which were only read once after launching a game scenario). So, you can launch the selected game and edit the 'notes.html' file and just re-open the 'game notes' window to see any updates.

There is also no need to do any XML escaping of the 'html' content in the 'notes.html' file, you can write straight html into that file.

ubernaut

@lafayette whatever happened to updating the splash screen logo we still doing that or what?

LaFayette

@ubernaut Nobody ever sent me an updated graphic.

ubernaut

@lafayette i think did anyway give me specs and i will send you whatever you need

LaFayette

@ubernaut This is the image: https://github.com/triplea-game/assets/blob/master/game_headed_assets/launch_screens/triplea-logo.png

The dimensions don't need to even be the same, just preferably similar.

ubernaut

@lafayette you want it without the base, right? where should i put it?

LaFayette

@ubernaut Not sure how you mean "without the base". I'm indifferent to how it is updated; the cut-off drop shadow I never really noticed. If it can be improved cleanly, I'm for it.

Ideally you'd submit a PR to replace the image, in which case all I'd have to do is click a button to accept the update. Failing that, any way to get the image to me is okay.

ubernaut

This post is deleted!

ubernaut

@lafayette Screen Shot 2022-10-22 at 11.09.41 AM.png
that's what i mean by the base not sure how to do a pull request didnt see anything on that page that seems to create one for that file

LaFayette

@ubernaut Yes, seemingly without the base.

For PR, go up one folder to:
https://github.com/triplea-game/assets/tree/master/game_headed_assets/launch_screens

Look for the 'add files > upload file' button. Uploading a file with the same name should do an overwrite. The web-UI should guide you through the rest of the steps to submit a PR.

ubernaut

@lafayette tried to it's telling me this tho:

Uploads are disabled.
File uploads require push access to this repository.

LaFayette

@ubernaut This may help: https://ardalis.com/how-to-add-files-to-a-github-repo-you-don’t-own/

Distilling the steps a bit:

create a fork (there is a button for this on the upper right of the repository page; this will create a copy of the repository that you own under your own namespace (rather than triplea-maps))
upload the file using the UI to your fork (prefer to create a new branch when you do this, but not required)
create a pull request (follow steps 1-n on this page: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork)

ubernaut

@lafayette just tried it but it put the pfile int he top level not sure if i did it right not

LaFayette

@ubernaut The PR is open, that is good - but you do need to overwrite the existing file. The location is significant.

ubernaut

@lafayette i'm lost lol can you take the file from there and do it for me?

LaFayette

@ubernaut When you uploaded the file, I think you only needed to navigate to the directory it needed to be in first. I grabbed the image and updated triplea-game/assets with it.

ubernaut

@lafayette thanks i thought i had but i could tell after i did it it it copied the entire thing

beelee

@lafayette was able to successfully update the Game Notes.

I still think they should revert to 2.5 for how they are displayed. Not only do you have to go through another step, by hitting Help to bring up Notes, the right side bar then cuts into the map view.

A lot of times, especially with a new map, one will want to look at the map the same time they're looking at the Notes. This limits your view. You can only scroll one way as well, if Notes are fully extended. The window won't Close/Hide without clicking x.

The new space isn't even being used.

Old
Screenshot from 2022-11-09 04-15-47.png