Total World War: December 1941 3.0.0.6
-
@ubernaut Yeah, I recently updated all the notification image paths to not reference sourceforge. For some reason, it appears the path is incorrect for at least Macs. It tries to reference the notification images in the map zip like this:
<img src="/doc/images/thailand.png"/>@RoiEX Do you have a mac or maybe even a linux box and could test if you can see these notifications in TWW?
TripleA Developer with a Passion for AI: https://forums.triplea-game.org/topic/105/ai-development-discussion-and-feedback
-
@redrum thanks for looking into it.
also for whatever reason that dice bug came back too . 
i will try to see if it goes away next time i quit.
"You should never have told me horses sleep standing up, it gave me a mental block." - Mister Ed
-
@ubernaut Actually can you test something for me. Can you edit the notifications.properties file in the TWW/map folder and change this line:
Startgermany=<body><img src="/doc/images/startgermany.png"/></body>to
Startgermany=<body><img src="startgermany.png"/></body>Then launch a new TWW game and see if the initial germany notification appears properly.
-
@redrum nope
i also tried "/startgermany.png" -
@redrum I have access to a mac on Tuesday, what exactly do you want me to check?
I haven't followed the whole conversation -
@RoiEX I updated TWW notifications.properties to reference local images from the map zip rather than sourceforge links: https://github.com/triplea-maps/total_world_war/commit/5984d1cec952bfc7e07fa9dde36af188a4d17a63
But it appears the images aren't showing for @ubernaut who has a mac but works fine for me on a windows machine. Trying to isolate if its a mac issue with the image path or a specific issue for him.
The notifications appear as popups once you start a new TWW game and click past the bid phase.
@ubernaut Can you make sure you don't have multiple TWW maps in your maps folder. Or clear out your maps folder and redownload.
-
@redrum yeah it was clear just the one.
-
@redrum I dug a little bit into the code and haven't found a real reason, but a couple of places where the system could be tripping up.
This code seems to strip out html tags out of notification properties if the string is too long. Shouldn't be the case here, but still weird.
Just before the HTML is parsed and interpreted to be shown to the user the engine "localizes" the external HTML resources:
This means 2 Things:
- It's not necessary to have the /doc/images/ prefix in the src attribute because everything except for the basename will be stripped away
- Removing the sourceforge part of the URL in the src attribute has 0% effect because everything except for the basename will be stripped away
Also if the engine tries to search for a resource that doesn't exist, an exception will be logged and an error window should pop up.
So it's clearly not the change on your end, at least for latest master. I have fiddled around with the LocalizeHtml class in the past, so maybe on the latest stable there is actually a difference, but probably not for TWW compatible versions.So because there is no exception this probably means that the tag gets removed at some point for some reason we don't know, but I think it's fairly unlikely the issue is cause by the OS at this point.
-
@RoiEX Yeah, I had noticed the /doc/images/ wasn't needed and that's why I asked to try without that as well. I'm going to remove those prefixes from the map.
Only thing I could think of is a duplicate map or something causing image loading issues.
-
-
@RoiEX the first thing did nothing the second thing seemed at first to do nothing (same blank dialog) but then a second dialog came up with the test message.
-
I'm even more confused now
But at least something is happening, not sure what to do with this knowledge though. -
@redrum For that save I think it's easier if I pass you through the lobby! But the situation of the non working converted barracks repeated in a few games. And I think it's easily duplicable as well in any game.
@Hepps Adding, I feel Armour can use at least also a +1 attack through some technology - and eventually also added defence to have a final base of 7 / 6 / 2 (Dare say diluted in 3 different techs - including improved armour giving +1 defence). Currently they're easy to hard counter with AT (that can gain through techs). I believe Armour should upgrade as well through tech to keep in tune a line of armour piercing vs armour technology race (if that ever happens). To be a 6 costing unit they have lots of penalties in many terrain ontop of having a direct hard counter if they're spammed.
-
the dice thing seems to be random.
"You should never have told me horses sleep standing up, it gave me a mental block." - Mister Ed
-
@redrum Notifications seem to work fine for me on a mac
-
@RoiEX Ok, thanks.
@ubernaut Can you try downloading Iron War and checking to see if you see its notifications appear properly. You should see this right after the map starts up:
If you see that fine then its almost definitely an issue with either your TWW map being corrupted or you having multiple TWW maps. If you don't see that then its probably your TripleA or Java version and you should try removing them and doing a clean install.
-
@redrum well, iron war notifications work fine but i have completely removed and reinstalled tww several times now to no effect.
-
@ubernaut Ok. Have you tried clearing your entire downloadedMaps folder? Then redownloading TWW.
-
-
@ubernaut The local.cache file probably has nothing to do with it, more or less recent versions of the engine don't even use this file anymore, so deleting it won't change a thing.
I'm 100% sure I'm using the latest version of the map, at work I didn't even have the latest version of TripleA installed and the only map I had was 270BC because it's the first entry in the list.
If you want, I can give you the version just before the change if you want in order to double check.There are some things I'm not sure about though, obviously at work I can't just spent an hour trying to reproduce the issue, so everything has to be doable in 5 minutes or less.
That's why I just checked if some notification showed up correctly, not the specific one referred to above.
If you give me unambiguous instructions on what to do so I do the exact same thing as you when loading the map (including map and player selection) I could try again on Friday.
But I doubt that this will change anything because as mentioned earlier @redrum's change should not affect the behaviour at all.
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login