TripleA development
-
Does this link work for you?
https://github.com/orgs/triplea-maps/teams/mapadminsDo you see any way to make the transition easier so we can move the content discussions of guides to github?
This is a pretty pervasive problem. I've come to find that splitting conversations is often more harmful than trying to move them to the right place. Only suggestion I have is to spam the PR link a bit more, and be more explicit that you would prefer feedback on the branch or a PR rather than in this thread.
Overall this thread is seemingly not well focused anymore and probably the conversation should wrap up here or regain focus back to the OP.
-
@frigoref said in TripleA development:
@thedog @beelee @LaFayette
Please don't take offense in my question, but I am genuinely interested in what prevents you from using the link to make a pull request to contribution page, but you are still writing - even some extensive - posts here about what should change?yea i made one a few days ago. I'm gonna do a test one now showing the steps for others
-
@TheDog i assume you already have triplea forked since you tried to add a map. This process is quite a bit easier. Here's what I did.
Go to frigorefs contribution page here https://github.com/frigoref/triplea/blob/docuStartGuide/docs/contribute.md
You should see a pencil icon upper right
Click on that and scroll to the tbd area you want to change. here I changed tbd to To Be Determined
then scroll down to "Propose Changes"
and give an explanation of what your changing.
Click "Create Pull Request"
Then there will be another "Create Pull Request" button (idky theres two) and you can also see the changes you made
Anyway, hit Create Pull Request again and you'll then see a PR listed in the upper left. You'll notice 2 open ones in this example. You can look at previous ones that have been closed as well by clicking on Pull requests. Works the same as issues basically which you've already been doing on the main triplea page/repo w/e it's called lol
Anyway, that's it. I'm gonna close this test one now.I assume since this is "public" the pencil icon shows up as long as you have a fork of the triplea-game. If it doesn't show up, you'll have to ask someone more knowledgeable than me lol
Anyway, when in doubt, just keep hitting the Big Green buttons : )
-
Pencil icon should always be there. It'll prompt for you to create a fork eventually if you do not have one created.
-
@lafayette the link is not working for me. I get a 404 error.
-
@beelee
So I thought I had followed beelee's guide and added 4 lines of text to the Map Maker section, but they did not show up, what did I do wrong? -
@thedog it's there now. It takes git a minute or two to process stuff and you need to reup/reload w/e : ) anyway, go to frigs page again and you'll see 2 PRs open
Click on yours
and then the hilighted line and it'll show your PR
Once frigoref merges (if he decides it's good to go) then it'll be in the updated/latest thingy ? : )Also it will give you an option to delete branch once that is done. Go ahead and kill it after it's merged
-
beelee, thanks!
A quick vent at github, why I cant I just see what my changes look like when merged into the original document.
It just needs two buttons or a toggle.
- current version
- my suggestions
So I can toggle between the two, its so unfriendly.
Frustration over.https://forums.triplea-game.org/tags/thedog
https://forums.triplea-game.org/topic/3741/curated-best-top-maps-triplea-guides -
@thedog there is a "view file"option to see undiffed changes (ie, the end result). google'ing frustrations can sometimes be a very quick way to remove those frustrations
-
@thedog FWIW:
-
Thanks, I should google more.
-
-
@lafayette , @beelee , @Panther , @RogerCooper , @Cernel , @RoiEX
We have the following open points where I would like you to chip in, let me know who else could help out or let me know if there is nothing more you can add to our new contribute page:
Release Tester
How to become one
tbd
Issue Manager
Skillset
tbd
Contributions
tbd
How to become one
tbd
Developer with Merge Rights
How to become one
tbd -
@frigoref said in TripleA development:
@lafayette , @beelee , @Panther , @RogerCooper , @Cernel , @RoiEX
We have the following open points where I would like you to chip in, let me know who else could help out or let me know if there is nothing more you can add to our new contribute page:
Release Tester
How to become one
tbd
Issue Manager
Skillset
tbd
Contributions
tbd
How to become one
tbd@lafayette , @beelee , @Panther , @RogerCooper , @Cernel , @RoiEX
Please a last review of the page and some feedback. Then it's done. -
@frigoref said in TripleA development:
Just one role open, please chip in or suggest a suitable contact:
Issue Manager
Skillset
tbd
Contributions
tbd
How to become one
tbdPR sent.
-
@panther Great, last okay for the completed page please
-
@frigoref Looks good for now, IMHO. Changes might be applied at any time later as things evolve...
-
-
@frigoref
I dont have a link/email/post yet. -
@thedog
Thanks for the info. Please try
https://cla-assistant.io/triplea-game/triplea?pullRequest=10457
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login