NodeBB 1.17 and later breaks PBF compatibility
-
As already noticed on axisandallies. org and potentially here after the next forum software update:
-
@panther i thought we already had that issue here and fixed in prerelease is this something new?
-
Yes, this is new.
I can reproduce it with the current prerelease:
You won't notice this on this forum, yet, as this forum runs on the very outdated NodeBB 1.16.2 while the current version is 1.19.1.
TripleA (as well as this forum's software) needs to be updated to support PBF on forum software versions >=1.17.0.
-
@panther yea i saw where Djensen talked to the nodebb guys and they found where it broke but Idk anything about a fix. Not sure, but my guess is triplea needs to change to make it work ?
-
@panther gotcha just making sure
-
Joy, perhaps that update can be done in a backward compatible way in 2.6, though it'll be an ugly hack. I don't know how we can preserve 2.5 to still work after updating the forum software.
-
@lafayette I don't know how the code works but if this piece is encapsulated in it's own class, then you can extract an interface and have two implementations of the interface. Then you can use a factory method to return the correct instance based on a key. In this case the key could be some constant that represents the forum in question.
-
@djensen47 I was more thinking how to handle updating the TripleA forum. Presumably we'll need to handle both formats; I think 2.6 will precede the forum upgrade. To handle this in code it will be seemingly ugly as the code will have to do things like "is this map?" no, okay, "is this a list?"
-
@lafayette I was thinking the same ... maybe I need to see the code. Where's the entry point for this code? E.g., where I can see the forum posting workflow?
-
@djensen47 Is it feasible to roll back to the previous version of NodeBB?
-
@simon33 The previous version had other bugs affecting forum functionality.
-
I created https://github.com/triplea-game/triplea/pull/10059/files to quickly fix this issue without breaking compatibility. Not pretty but it should work for now
closed Fix NodeBB banned check #10059
-
Thank you.
Unfortunately no one has merged this until now.
Can you maybe self-merge this?However, this would result in another 2.6 -prerelease - so in a version that for other reasons currently can't be recommended for general usage, at least as far as I understand it. Any chance we can have sort of a fix that runs with the current stable?
-
@panther yea adding this fix only to another 2.5 would be the way to go. Idk if that's simple or not. People would still need to DL the new one but without the 2.6 stuff that is still being worked on.
-
@roiex Message me if you need someone to review it.
If the current master isn't in a good state to release soon then it might be better to patch the current release version and release that.
-
If you have like 5 Minutes, please feel free to review it, it's a rather small change. Not really clean but it should work for now
-
@roiex Yeah, looks good. I merged it. Do you know if we are close to pushing out a release? Otherwise, we should probably consider putting that fix into 2.5 and pushing it out.
-
I just want to bring this issue back to attention. It seems like we get no answer to the question how close a 2.6 release actually is.
This seems to indicate that it might be useful to push an updated 2.5 stable.
-
@panther This is the 2.6 project: https://github.com/triplea-game/triplea/projects/25
Volunteers to help come up with a list of any other items that need to be fixed would be really welcome (https://forums.triplea-game.org/topic/2999/2-6-release-getting-close-need-volunteers-to-help-beta-test-2-6/3)
-
Unfortunately this fix doesn't work as expected.
I have just verified
https://github.com/triplea-game/triplea/issues/10117and can confirm it with 2.6.571.
Anyone else tested PBF on A&A .org using a current prerelease?
cc: @redrum
