Can we fix TWW?

Nothingtoseehere

@Cernel: Since I want to start my next game soon, I was curious, if you want to share the map in its current state, so we can test it by playing it.

LaFayette

If someone has a fully patched XML file that fixes this issue, please post it as an attachment. That would be a good building block that others can work from.

After we have an updated XML file that is validated to fix this issue, then we just need to upload it (which should take 5-20 minutes to do): https://docs.github.com/en/repositories/working-with-files/managing-files/editing-files#editing-files-in-another-users-repository

zlefin

@LaFayette

Did a bug fix for TWW.

bugs fixed:
carriers having 2hp before that tech is researched.
repairs for minor nation entrench/fortifications
alpine infantry placement locations in Eastern Central US
Liberations not always giving proper engineer+factory
advanced mechanization giving +2 att instead of +1 att

5 bugs fixed; the other issues listed in the thread were mostly could not reproduce; one of them used quite old versions of the engine and map. the sweden capturing an RC one just doesn't matter enough to fix, not even sure it's a bug anyways.
My testing indicates the fixes work, but testing has not been extensive at all, only rudimentary.

corrected the name of the file and reloaded it, since I don't know of another way to fix it. below is the one with the fixed name.

Total_World_War_Dec1941_3.0.xml

ubernaut

@zlefin

ubernaut

@zlefin also is this downloadable haven't played a game in forever would be happy to test

Nothingtoseehere

@ubernaut Would be happy to test along with you.

zlefin

@ubernaut

It can be manually downloaded and installed from here in the thread. It can't as yet be downloaded from the normal map download from the depository (or is it repository?)
Lafayette would need to handle that, which is why he was tagged.

Nothingtoseehere

@zlefin The file name has an additional . at the end. I had to remove it and replace the original file then it worked and I tested that carriers no longer get replaced with damaged carriers without the tech.

zlefin

@nothingtoseehere said in Can we fix TWW?:

@zlefin The file name has an additional . at the end. I had to remove it and replace the original file then it worked and I tested that carriers no longer get replaced with damaged carriers without the tech.

Ok, odd how that happened; I fixed it and put in an uploaded version with the proper name. I don't think lafay has been on so it shouldn't be a problem for anyone.

ubernaut

@nothingtoseehere lesssgo!!!

Shonn

I am not sure how I can download the fixed version of TWW from its present bugs.

Can anyone explain, since it does not seem included yet in the downloadable maps?

beelee

Hi @shonn

Idk if this is the latest but it's the latest on github. https://github.com/triplea-maps/total_world_war

Hit the green Code button and then Download Zip.
Open zip and rename the folder by removing the "-master" at the end.

Open triplea folder and go to downloadedMaps.
Replace your TWW

Might want to save the old one just in case

I think @ubernaut should know which is latest. Unless I've confused him with someone else

ubernaut

@shonn the link is in this thread:

https://forums.triplea-game.org/post/59586

Shonn

@ubernaut This is exactly the thread and I've not found a link that gives me a download.
I get some XML new webpage at best in a link above.

ubernaut

@shonn u need to download that file and replace it inside the folder

Shonn

@ubernaut Thanks, I should have managed. I was simply 'opening' it in the browser instead of 'saving the link'.

ubernaut

@shonn

beelee

@ubernaut I think redrum used to play TWW could ask him to add it to git. Might make it a little easier for people

ubernaut

@beelee i think @zlefin i just waiting for us to confirm fixes and any new problems

zlefin

That is correct; I've found noone to do any test games with myself in the lobby, so ubernaut's game plus my own internal testing verifying the bugs themselves were fixed is all we've got. So I'm waiting for ubernaut's game to finish; though we could go ahead with it now.