Can we fix TWW?

[beelee]

@rogercooper

yea just to clarify, I'm not doing any work on the map.

looks like it has already been updated. just need it updated to triplea

[ubernaut]

@rogercooper i believe all @zlefin did was patch the bugs that came from engine changes in 2.6

[zlefin]

I'm still hoping to see the update get pushed properly so it's in the map repository; maybe next time @LaFayette is around?

[ubernaut]

@zlefin hey thanks supposedly i have the permissions to do map edits but i dont rly understand how github works. i have noticed one tiny remaining bug with map i think the chinese anti-tank tech doesn't activate the little badge it normally does here is a saved game showing the issue:

autosaveBeforeEndTurn.tsvg

randomly just had an issue without the game someone accidentally disabled two of the neutrals in our game and now it seems like i cannot re-enable them. do u happen to know any way around this or do we just need leave them neutral now?

[wc_sumpton]

@ubernaut

Any changes made to map/game files will not be reflected in a save game. ie: I found that Chinese Advance Anti-Tank Gun was not listed in unit_icons.properties. Making changes will not correct the save game since that file is self-contained.

Cheers...

[ubernaut]

@wc_sumpton yeah no i understand that this game was started with the modified xml so there must be something off in that file is all im saying. all the other faxctions/units seem to work properly as far as i have seen so far at least

my question was about the deactivation of 2 of the neutral countries is there any way to fix that or once they are disabled they cannot be re-enabled?

to be clear one of us must have unchecked the 'use' in the previous turn next to two factions. i have yet to be able to figure out a way to re-check those boxes.

[wc_sumpton]

@ubernaut said in Can we fix TWW?:

my question was about the deactivation of 2 of the neutral countries is there any way to fix that or once they are disabled they cannot be re-enabled?

I don't think that once game was saved with deactivated players, that those players can be reactivated. I think this was purposely. It is easier to remove information/players to the UI then it is to add.

Cheers

[ubernaut]

@wc_sumpton thanks that's wat i was thinking just figured i'd ask

[wc_sumpton]

@ubernaut

No problem. I could check the engine code. In this case I don't think that is necessary.

Cheers...

[beelee]

@ubernaut said in Can we fix TWW?:

to be clear one of us must have unchecked the 'use' in the previous turn next to two factions. i have yet to be able to figure out a way to re-check those boxes.

Hi ubernaut
Not exactly sure how it works but can you add a Notification for when that happens ? Or maybe there is one and it just got missed ?

[wc_sumpton]

@beelee

@ubernaut is talking about the player selection menu, prior to starting a game, and un-checking to "Use" box.

Cheers...

[ubernaut]

@beelee any time u start a game u have the option to uncheck the neutrals the option is not presented for the other factions

[wc_sumpton]

@ubernaut

Great minds... I'll just let you have this one!

Cheers...

[ubernaut]

@wc_sumpton

[beelee]

@ubernaut

ahhh ... yea Idk if you can add something after game sart, so it shows the list agin or not. A "are you sure? type thing but not exactly.

Well tough duty there

[ubernaut]

@beelee yeah idk im not very skilled at manipulating xml files

[zlefin]

@ubernaut

I figured out how to fix chinese anti-tank display, but doing so requires changing other files than the xml, I don't know to what extent that complicates the updating process, or what would be considered the most effective way to post such an update. I'll wait for laf to chime in on what's best for that.

[beelee]

@zlefin

You could make a PR to the repo with the changes and when whoever owns the repo accepts it, it can move on through the process.

Edit
I just checked and @Myrd did the last update, so you might wanna ask him.

[ubernaut]

@beelee @zlefin i believe i have permission to do that i just need someone to tell me what to do

[zlefin]

unit_icons.properties

this is the fix to the chinese antitank icon issue; it replaces the prior file unit_icons.properties inside the 'map' folder inside tww

I don't know how to do PRs for the repo or how to adjust things in the depo, I just know how to adjust the files inside the tww map itself. (the other change involves changing the file in tww(whateveritspropernameis)/map/games/ the 3.0 xml for the most recent fixed one I had up in this thread.