2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6

Alexei Svitkine

@thedog thanks! When it happens, could you post the save right before the combat phase when it happened?

TheDog

@alexei-svitkine
Here is a save set, but annoyingly its not 100% reproducible, its random, it occurs in Italy's Combat phase.
Save of USSR just before Italy's turn, if you need it?
1941-T7-autosaveAfterUSSRNonCombatMove.tsvg

Save of Italy just before the combat phase, where randomly the error occurs
1941-T7-autosaveAfterItalyCombatMove.tsvg

I think it might be the Flag (infrastructure non combat) in Moscow, but I cannot be sure.

If you need the map, hopefully this version v120 works
https://drive.google.com/file/d/1Q5XcTxMNdUZVAjjTWbz4mw0gL-Bjlw6r/view?usp=sharing

My testing is now on v121 and the saves come from that.

TheDog

@alexei-svitkine
Just noticed I have given the Flag

<option name="tuv" value="10"/>

This might confuse things. I use infrastructure tuv to guide the AI to make it important like Oil-Field and Lend-Lease-Depot

FYI, I also tested
https://github.com/triplea-game/triplea/issues/10647
it still errors occasionally, but Forest & Mountain (again infrastructure) dont have tuv

Alexei Svitkine

@thedog I can't load those saves with 120. Got a link to 121?

TheDog

@alexei-svitkine
Ah yes, a SZ got added, try this one v121
https://drive.google.com/file/d/1dWCWMTy6L9zBItGXw3RHEoOxUMbdVaVf/view?usp=sharing

Alexei Svitkine

@thedog said in 2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6:

If we want to entice players to migrate from 2.5 to 2.6 there is a one feature request that affects about 1/4 of the maps in the map downloads so about 50 of the 200+ maps.

It would make the purchasing of these units less frustrating as getting it wrong cancels all your purchases.

It is this

maxbuiltperplayer has ≤ on the purchase panel for each unit

the aaGun doesn't have a maxBuilt rule and hence no limit is displayed in the label

current unit count has been appended to the end of the Production tooltip (which makes the info easy to scan). It has been suggested this info can be useful to plan production count 2

infantry was maxed out using the max button.

production capacity is displayed on the panel at the bottom left 5/8 = 5 units currently purchased out of the 8 maximum production/placed allowed (if applicable)

See here;
https://forums.triplea-game.org/topic/2752/maxbuiltperplayer-error-resets-purchase-ui-was-how-to-limit-the-number-of-units-purchased/11

https://github.com/triplea-game/triplea/issues/9231

Although I didn't re-implement the above, I just landed https://github.com/triplea-game/triplea/pull/11818, which makes it so that if you get an error about your purchase, it won't clear your selections. So it's actually a pretty reasonable experience - if you select something incorrect, you will get a message box with the details when trying to end the purchase phase, which will tell you what's wrong, and then the purchase screen will be shown again with your previous selections which you can correct.

I think this should be a good improvement (and the UI stuff can still be done later if someone is interested to pursue it).

TheDog

@alexei-svitkine
Tried it and it does reduce the frustration!

If people want to download it and try it
https://github.com/triplea-game/triplea/releases/tag/2.6.14441

Cernel

@Alexei-Svitkine It seems you are working a lot on pushing this release, which is great.

Do you have an idea in months from now of when 2.6 shall be released?

Myrd

@cernel said in 2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6:

@Alexei-Svitkine It seems you are working a lot on pushing this release, which is great.

Do you have an idea in months from now of when 2.6 shall be released?

Well, my hope would be in the next couple of months, but it also depends on other team members. I think there's some map download and lobby server related stuff that I think @LaFayette would need to resolve, since I'm not really familiar with any of the server-side infra.

And I think @redrum wanted to look at fixing play-by-forum functionality.

On my side, I've just been focusing on fixing client / gameplay bugs - particularly, ones that are regressions from 2.5. I have a few more I plan to look at and of course, if new stuff is discovered, I can look at those too.

Cernel

@myrd Thanks for letting us have some hope. This 2.6 was quite the development purgatory.

ebbe

@alexei-svitkine

Yessss! that is a great improvement!!!
thanks for your contribution, I really appreciate!

as maxBuiltPerPlayer is a nice ballancing tool,
and by taking away the "having to order all over again in the
purchasing phase" it can be used without frustrations!

Cernel

About fixing PbF.

Is @redrum or @Myrd (Are @Myrd and @Alexei-Svitkine the same user?) going to fix PbEM too?

Unless I'm missing something, I believe that PbEM is broken since a long time, specifically the "Post Turn Summary" button is broken: I understand that users are reduced to get themselves a game-save at that point and upload and send it via E-Mail manually.

Or is this the same culprit as the PbF issue, so both are going to be fixed if any one of them is?

This is what you (or at least I) get when trying to use the "Post Turn Summary" button:
https://github.com/triplea-game/triplea/issues/11445

Here it is a video of back then when this button used to work:
https://youtu.be/c9cfHsoWQoI?t=870

The problem is that now it does not: if you click that button, you get the error reported where I linked.

(A disclaimer: I've never played PbEM, just tested it.)

Panther

@cernel
PBF is meanwhile an about two years old issue, communicated and discussed various times. Recently I have been in contact with @redrum on A&A .org. He said he is ready to look into the PBF issues once the forum software (NodeBB) will be updated. This affects posting turn summaries in PBEM, too.

Cernel

@panther said in 2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6:

@cernel
PBF is meanwhile an about two years old issue, communicated and discussed various times. Recently I have been in contact with @redrum on A&A .org. He said he is ready to look into the PBF issues once the forum software (NodeBB) will be updated. This affects posting turn summaries in PBEM, too.

If it is the same problem (with the "Post Turn Summary" not working) for PbEM and PbF, then it has nothing to do with any forum software (because PbEM does not use any forums), so I'm not sure if waiting for the next forum software update has any value at all.

Panther

@cernel
NodeBB updates sometimes lead to incompatibility between TripleA and forum login- as well as posting to forum procedures. This is what @redrum will take care about.

However it cannot be excluded that the issue you experience in PBEM might affect PBF (additionally) too.

It is of course only PBF that is affected by the forum software. So I'm sorry for the confusion I added.

Myrd

@cernel said in 2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6:

@panther said in 2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6:

@cernel
PBF is meanwhile an about two years old issue, communicated and discussed various times. Recently I have been in contact with @redrum on A&A .org. He said he is ready to look into the PBF issues once the forum software (NodeBB) will be updated. This affects posting turn summaries in PBEM, too.

If it is the same problem (with the "Post Turn Summary" not working) for PbEM and PbF, then it has nothing to do with any forum software (because PbEM does not use any forums), so I'm not sure if waiting for the next forum software update has any value at all.

What's the "Post Turn Summary" issue? I thought the email problems was about sending emails themselves not working (e.g. due to auth problems with different email providers).

Cernel

@myrd said in 2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6:

@cernel said in 2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6:

@panther said in 2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6:

@cernel
PBF is meanwhile an about two years old issue, communicated and discussed various times. Recently I have been in contact with @redrum on A&A .org. He said he is ready to look into the PBF issues once the forum software (NodeBB) will be updated. This affects posting turn summaries in PBEM, too.

If it is the same problem (with the "Post Turn Summary" not working) for PbEM and PbF, then it has nothing to do with any forum software (because PbEM does not use any forums), so I'm not sure if waiting for the next forum software update has any value at all.

What's the "Post Turn Summary" issue? I thought the email problems was about sending emails themselves not working (e.g. due to auth problems with different email providers).

@cernel said in 2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6:

This is what you (or at least I) get when trying to use the "Post Turn Summary" button:
https://github.com/triplea-game/triplea/issues/11445

Here it is a video of back then when this button used to work:
https://youtu.be/c9cfHsoWQoI?t=870

The problem is that now it does not: if you click that button, you get the error reported where I linked.

(A disclaimer: I've never played PbEM, just tested it.)

Cernel

@myrd said in 2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6:

@cernel said in 2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6:

@panther said in 2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6:

@cernel
PBF is meanwhile an about two years old issue, communicated and discussed various times. Recently I have been in contact with @redrum on A&A .org. He said he is ready to look into the PBF issues once the forum software (NodeBB) will be updated. This affects posting turn summaries in PBEM, too.

If it is the same problem (with the "Post Turn Summary" not working) for PbEM and PbF, then it has nothing to do with any forum software (because PbEM does not use any forums), so I'm not sure if waiting for the next forum software update has any value at all.

What's the "Post Turn Summary" issue? I thought the email problems was about sending emails themselves not working (e.g. due to auth problems with different email providers).

I'm not sure what you mean, but yes: the problem is only that no e-mail is sent to anyone. Isn't this all that the "Post Turn Summary" button is supposed to do when you are PbEM (not PbF)?

Panther

@myrd said in 2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6:

What's the "Post Turn Summary" issue? I thought the email problems was about sending emails themselves not working (e.g. due to auth problems with different email providers).

Indeed these are still existing problems related to email - but independent from the "Post Turn Summary" issue:

https://forums.triplea-game.org/topic/3061/
https://forums.triplea-game.org/topic/3157/

TheDog

@LaFayette
The "map-server" appears to be broke again.
https://github.com/triplea-maps

I have just uploaded Shogun Advanced and was wondering when it would appear in the TripleA 2.6 Downloadable list?

Checking on one of @RogerCooper many map uploads
Franco_Prussian_War, over 2 weeks ago, it is still not in the TripleA 2.6 downloadable list.

I downloaded it manually and tested the map.yml was correct, as expected it is, so ... The "map-server" appears to be broke again.

.
2.6 download list button
Also I note that 2.6 download list button has 3 states;

Map
Map ^
Map v

Map, sorts numbers, uppercase A-Z, then lowercase a-z maps is only available once on first seeing/loading the panel, in my view this is not needed and will be confusing to downloaders when the other two options do what is intended.

@Alexei-Svitkine @Myrd please could you take a look at this?

.
For reference, Map ^ & Map v sort is different to Map being;

Map numbers, uppercase A-Z, then lowercase a-z
Map ^ numbers 1-9, case insensitive a-z
Map v case insensitive z-a, numbers 9-1