NodeBB 1.17 and later breaks PBF compatibility
-
@djensen47 I was more thinking how to handle updating the TripleA forum. Presumably we'll need to handle both formats; I think 2.6 will precede the forum upgrade. To handle this in code it will be seemingly ugly as the code will have to do things like "is this map?" no, okay, "is this a list?"
-
@lafayette I was thinking the same ... maybe I need to see the code. Where's the entry point for this code? E.g., where I can see the forum posting workflow?
-
@djensen47 Is it feasible to roll back to the previous version of NodeBB?
-
@simon33 The previous version had other bugs affecting forum functionality.
-
I created https://github.com/triplea-game/triplea/pull/10059/files to quickly fix this issue without breaking compatibility. Not pretty but it should work for now
-
Thank you.
Unfortunately no one has merged this until now.
Can you maybe self-merge this?However, this would result in another 2.6 -prerelease - so in a version that for other reasons currently can't be recommended for general usage, at least as far as I understand it. Any chance we can have sort of a fix that runs with the current stable?
-
@panther yea adding this fix only to another 2.5 would be the way to go. Idk if that's simple or not. People would still need to DL the new one but without the 2.6 stuff that is still being worked on.
-
@roiex Message me if you need someone to review it.
If the current master isn't in a good state to release soon then it might be better to patch the current release version and release that.
-
If you have like 5 Minutes, please feel free to review it, it's a rather small change. Not really clean but it should work for now
-
@roiex Yeah, looks good. I merged it. Do you know if we are close to pushing out a release? Otherwise, we should probably consider putting that fix into 2.5 and pushing it out.
-
I just want to bring this issue back to attention. It seems like we get no answer to the question how close a 2.6 release actually is.
This seems to indicate that it might be useful to push an updated 2.5 stable.
-
@panther This is the 2.6 project: https://github.com/triplea-game/triplea/projects/25
Volunteers to help come up with a list of any other items that need to be fixed would be really welcome (https://forums.triplea-game.org/topic/2999/2-6-release-getting-close-need-volunteers-to-help-beta-test-2-6/3)
-
Unfortunately this fix doesn't work as expected.
I have just verified
https://github.com/triplea-game/triplea/issues/10117and can confirm it with 2.6.571.
Anyone else tested PBF on A&A .org using a current prerelease?
cc: @redrum
-
@panther I made another fix for the new nodeBB version and it was just merged: https://github.com/triplea-game/triplea/pull/10206
I tested myself and was able to post to A&A.org with the latest pre-release. I would appreciate if a few others can test it to verify then we can look to release a patch version with the fixes.
TripleA Developer with a Passion for AI: https://forums.triplea-game.org/topic/105/ai-development-discussion-and-feedback
-
@redrum what exactly would like me to test? sorry, i can be slow sometimes
"You should never have told me horses sleep standing up, it gave me a mental block." - Mister Ed
-
Sounds like this is almost resolved! That is great because while able to do this manually it is much more of a pain than being able to push a single button to post. Thank you in advance for getting this fixed!
-
@ubernaut said in NodeBB 1.17 and later breaks PBF compatibility:
@redrum what exactly would like me to test? sorry, i can be slow sometimes
The test is about using the current TripleA pre-release with PBF on axisandallies.org/forums.
-
@redrum said in NodeBB 1.17 and later breaks PBF compatibility:
@panther I made another fix for the new nodeBB version and it was just merged: https://github.com/triplea-game/triplea/pull/10206
I tested myself and was able to post to A&A.org with the latest pre-release. I would appreciate if a few others can test it to verify then we can look to release a patch version with the fixes.
Very cool! Thanks a lot. I have tested prerelease 2.6.616 on axisandallies.org/forums successfully. Now it works as expected.
Yes a patch version would be very welcome!
-
@nothingtoseehere said in Google mail with TripleA issues (was: New Play By Forum Game):
@panther Does this mean, that PBF is possible again with the newest pre-release? If so is there still an issue with loading maps on pre-release versions of the client?
Yes, PBF is possible with the current pre-release, indeed.
In order to download maps you need to alter a setting in the Engine Preferences.
In the tab "Testing" switch "Lobby URl Override" to "Pre-Release".However @redrum suggested a patch version above - that might at the moment be preferable rather than a pre-release.
-
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login