world_war_ii_v5_1942 is incorrectly linked and installed

Panther

When I want to download the original map world_war_ii_v5_1942 - one of the core games - via TripleA that is represented by the map-repository
https://github.com/triplea-maps/world_war_ii_v5_1942
and contains the WW2v5_1942_2nd.xml as well as the WW2v5_1942_2nd_TR.xml

I instead get the files from (probably) this repository:
https://github.com/triplea-maps/ww2v5_variants
that contains
WW2v5_1942_2nd_Edition_High_Production_Mod.xml as well as
WW2v5-BuildCaps.xml as well as
WW2v5-Maintenance.xml

instead of the original game.

In case I manually install the correct repo-files, I get an update information - and executing the update overwrites my (correct) installation with the wrong files.

So it looks like world_war_ii_v5_1942 is linked to the wrong repository.

Is this something you can please take a look on, @rogercooper ?

cc: @lafayette

TheDog

@Panther
I have this downloaded in May 2024
https://drive.google.com/file/d/1IfoiVd2UM9B72M43PjlisN2syINajoO5/view?usp=sharing

Hopefully it has what you need?

Panther

@thedog Thanks a lot.

I can still get the correct download containing the correct files manually from
https://github.com/triplea-maps/world_war_ii_v5_1942

But obviously the list of Downloadable Maps in TripleA has linked this map to a wrong repository.

TheDog

I have tried to fix some of the problems on
https://triplea-game.org/maps-list/maps/

but the changes are not being reflected.

That site might be same as the TripleA download list ?

Panther

@TheDog Very good idea - as when you go to

https://triplea-game.org/map/world-war-ii-v5-1942/

and klick on Manual Download

you will see that this is incorrectly linked with
https://github.com/triplea-maps/ww2v5_variants/archive/refs/heads/master.zip

instead of
https://github.com/triplea-maps/world_war_ii_v5_1942 /...

what is the cause of the problem., indeed, as I think that this list is relevant for the TripleA-internal download-list, too.

(BTW the triplea_maps.yaml is correct.)

wc_sumpton

@panther, @thedog

The problem is with the map.yml. ww2v5_variants was created without the map.yml. To create the map.yml, mapName in the xml was used which is "world_war_ii_v5_1942" in WW2v5-BuildCaps.xml and WW2v5_1942_2nd_Edition_High_Production_Mod.xml while WW2v5-Maintenance.xml has "ww2v5_variants".

There is also World War II v5 1942 2nd Ed. (High Production Mod) which has a good map.yml but WW2v5_1942_2nd_Edition_High_Production_Mod.xml mapName has "world_war_ii_v5_1942".

The map.yml would need to change for ww2v5_variants v2026-06 (2.7) does not use the mapName in the xmls.

Cheers...

Panther

@wc_sumpton Cool, thank you.
Would this correct the entry on https://triplea-game.org/map/world-war-ii-v5-1942/ (automatically), too? And the list/connection in "Download Maps" within TripleA, too?

beelee

@Panther

I'm not sure the current process but I believe I saw the other day where the yaml has been removed, so you have to do it a different way.

Roger probably knows.

That or whoever can access the repo can correct it and then you'll get the new/fixed one when you DL

Panther

So what I understand here is

that the map_name needs to be changed to

map_name: ww2v5_variants

too?

Can anyone explain the current way how the map-info from the map-repository is transferred to the "Download Maps"-list in TripleA as well as to
https://triplea-game.org/maps-list/maps/
respectively
https://triplea-game.org/map/*specific map* ?

beelee

@Panther

Here's a quick How to Guide you can link people to until it gets fixed

https://forums.triplea-game.org/topic/4361/how-to-manually-download-world_war_ii_v5_1942-or-any-map

LaFayette

I fixed the map_name for this map

@panther I opened a new thread with an answer to your question: https://forums.triplea-game.org/topic/4362/doc-map-population-on-website-and-download-list

Panther

@LaFayette said:

I fixed the map_name for this map

@lafayette
Unfortunately nothing has changed. Still the wrong files from the incorrect repository are downloaded.
I should get the files from
https://github.com/triplea-maps/world_war_ii_v5_1942

but instead I get those from
https://github.com/triplea-maps/ww2v5_variants

using the ingame "Download Maps" feature.

RogerCooper

@LaFayette This is really odd. The link in triplea_maps.yaml is correct

  url: https://github.com/triplea-maps/world_war_ii_v5_1942/archive/refs/heads/master.zip

And here it is on GitHub

I see that @DanVanAtta just made some changes to ww2v5_variants, so maybe he has already fixed the issue.

LaFayette

It takes a little while for the support server to come back to re-index the map. I updated the DB directly to speed that process up, should appear fixed now.

triplea_support_server=# select map_name from map_index where repo_url = 'https://github.com/triplea-maps/ww2v5_variants';
       map_name       
----------------------
 world_war_ii_v5_1942
(1 row)

triplea_support_server=# update map_index set map_name = 'ww2v5_variants' where repo_url = 'https://github.com/triplea-maps/ww2v5_variants';
UPDATE 1

triplea_support_server=# select map_name from map_index where repo_url = 'https://github.com/triplea-maps/ww2v5_variants';
    map_name    
----------------
 ww2v5_variants

Panther

I can confirm that it downloads fine now. That already was a good example for the workflow.
Thank you