Screen Won't Center on Capital at Turn Start with Tech Off
-
@brazza said in Screen Won't Center on Capital at Turn Start with Tech Off:
Oh thanks, I misunderstood.
No problem. It happens to the best of us (and also those of us that are not so good).
@brazza said in Screen Won't Center on Capital at Turn Start with Tech Off:
Sure I should be able to fix it. I will take it once the issue is opened.
That's still debatable. I'm really not sure what would be wanted. But thanks for the offer, it is greatly appreciated.
Cheers...
-
yea idk might be more of a feature request as opposed to bug fix ?
@Cernel how would you phrase it ? Do you want to open a git issue so @Brazza can work on it ? I'm not sure the best way to word it.
Edit
I guess I could go with the topic/thread title. I don't really want to call it a bug though.Edit 2
I guess maybe it's a bug since it does it when tech is on. -
The problem is centering on the player's capital at the start of their round. It would very disorienting if TripleA centered on every step. So, the engine does this only on the first step. If the first is skipped so is the centering.
If centering is important to the map maker, then it should be designed so that this first is not missed.
This, IMHO, is an XML problem, and is solvable. So, I see no need for any engine change.
Again, that is just my opinion.
Cheers...
-
To me this is a non-issue, completely solvable. There are other things that, IMO, are more important. The "Active Units" window located in the lower right corner. It's broken. Because of its uselessness, l drought many people use it. It should either be fixed to work properly or just removed. It's a simple fix.
Another simple improvement would be for the "Movement" window to show all the units that can move without having to set display all units.These are just a few, that would, IMHO, be better.
Cheers...
-
-
@wc_sumpton said in Screen Won't Center on Capital at Turn Start with Tech Off:
Thanks for the call out.
<!-- Germans Game Sequence --> <!-- Dummy step used to insure map is centered for human player (first step is used to center) --> <step name="germansNoPUEndTurn" delegate="endTurnNoPU" player="Germans"/> <step name="germansTech" delegate="tech" player="Germans"/> <step name="germansTechActivation" delegate="tech_activation" player="Germans"/> <step name="germansPurchase" delegate="purchase" player="Germans"/> <!-- Second purchase is used to give units per territory in case player loses all production capabilities --> <step name="germansNoPUPurchase" delegate="purchaseNoPU" player="Germans"/> <step name="germansPolitics" delegate="politics" player="Germans"/> <step name="germansCombatMove" delegate="move" player="Germans"/> <step name="germansAirborneCombatMove" delegate="specialCombatMove" player="Germans" display="Airborne Attack Move"/> <step name="germansBattle" delegate="battle" player="Germans"/> <step name="germansNonCombatMove" delegate="move" player="Germans" display="Non Combat Move"/> <step name="germansPlace" delegate="place" player="Germans"/> <step name="germansEndTurn" delegate="endTurn" player="Germans"/>Used in UHD WIP 1940-45 (mega_new_elk)
Again, thank you @beelee
Cheers...
I would actually also argue that the fact that this hack works at all is a problem too (an unwanted behaviour). In my opinion, the visual should not be centred on "germansNoPUEndTurn" (ever) because that phase requires no actions from the player.
-
@brazza said in Screen Won't Center on Capital at Turn Start with Tech Off:
@wc_sumpton
Oh thanks, I misunderstood.Sure I should be able to fix it. I will take it once the issue is opened.
https://github.com/triplea-game/triplea/issues/13241
-
@cernel
I see, I will start on it later.
Thanks for your trust! -
Another heads up when using this code, unfortunately, when playing by forum, it will ask if you want to post after the added endTurnNoPU step.
It will ask twice with the "are you sure" so it seems better to just one click on the mini map where you wanna go. Make for cleaner play and minimize any confusion.
Works great in local
Idk if the new pre auto centers now or not. Haven't tried it yet -
Using 2.7.15129 there is no centering. Game's start with the map located in the upper left corner. So instead of 'tech' or 'endTurnNoPU' nothing centers on the current players capitol.
Is the desired effect?
Cheers...
-
-
@wc_sumpton
The same with 2.7.15064 . So it must have been introduced between 14962 and 15064. -
-
Oh ? I hadn't been following. I thought it had been addressed. Evidently not.
I'd suggest giving frigoref a ping at the issue. He's been active lately.
Maybe @Panther has more information than I. -
@beelee @wc_sumpton No sorry, I don't have any further insights.
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login