2.6 Testing (Report 2.6 problems here)

[ubernaut]

This post is deleted!

[ubernaut]

@lafayette
that's what i mean by the base not sure how to do a pull request didnt see anything on that page that seems to create one for that file

[LaFayette]

@ubernaut Yes, seemingly without the base.

For PR, go up one folder to:
https://github.com/triplea-game/assets/tree/master/game_headed_assets/launch_screens

Look for the 'add files > upload file' button. Uploading a file with the same name should do an overwrite. The web-UI should guide you through the rest of the steps to submit a PR.

[ubernaut]

@lafayette tried to it's telling me this tho:

Uploads are disabled.
File uploads require push access to this repository.

[LaFayette]

@ubernaut This may help: https://ardalis.com/how-to-add-files-to-a-github-repo-you-don’t-own/

Distilling the steps a bit:

• create a fork (there is a button for this on the upper right of the repository page; this will create a copy of the repository that you own under your own namespace (rather than triplea-maps))
• upload the file using the UI to your fork (prefer to create a new branch when you do this, but not required)
• create a pull request (follow steps 1-n on this page: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork)

[ubernaut]

@lafayette just tried it but it put the pfile int he top level not sure if i did it right not

[LaFayette]

@ubernaut The PR is open, that is good - but you do need to overwrite the existing file. The location is significant.

[ubernaut]

@lafayette i'm lost lol can you take the file from there and do it for me?

[LaFayette]

@ubernaut When you uploaded the file, I think you only needed to navigate to the directory it needed to be in first. I grabbed the image and updated triplea-game/assets with it.

[ubernaut]

@lafayette thanks i thought i had but i could tell after i did it it it copied the entire thing

[beelee]

@lafayette was able to successfully update the Game Notes.

I still think they should revert to 2.5 for how they are displayed. Not only do you have to go through another step, by hitting Help to bring up Notes, the right side bar then cuts into the map view.

A lot of times, especially with a new map, one will want to look at the map the same time they're looking at the Notes. This limits your view. You can only scroll one way as well, if Notes are fully extended. The window won't Close/Hide without clicking x.

The new space isn't even being used.

Old

New

I see absolutely no benefit from this change.

[beelee]

Starting with 2.6+31d2c60 https://github.com/triplea-game/triplea/releases/tag/2.6%2B31d2c60
The objectives tab disappears after you go to history.

When you exit History it doesn't come back.

Edit
Made a git issue https://github.com/triplea-game/triplea/issues/11305

To clarify it works correctly with the one before https://github.com/triplea-game/triplea/releases/tag/2.6%2B2c9a940

Edit
I believe this is where the error was introduced
https://github.com/triplea-game/triplea/pull/10844

[Cernel]

@lafayette

[Schulz]

@cernel I've noticed two things.

1. It seems I had accidentally changed the folder name of a map. I've fixed this.

2. I also get this error message in 2.5; Illegal character in opaque part at index 2: .../games/axis_ascension.xml

[TheDog]

@schulz
#2 I have had this error many times in 2.5 on many maps.
It occurs for me when loading/testing between 2.5 & 2.6

[wc_sumpton]

@thedog

Was going to say the same, but your post went up just before I could post.

Seconds -- merely seconds

Cheers...

[Cernel]

I joined the lobby with 2.6.14479, and there is not this problem.

[Cernel]

I'm using 2.6.14547 @LaFayette @Myrd.

[Cernel]

@cernel Just did the first round of "270BC Wars". Everything works fine (beside this error when chatting in the lobby but no problem chatting in the host).

[ubernaut]

@cernel yeah i was also getting this error wen connecting to the new lobby