TripleA development

Cernel

@frigoref You should add an intermediate step after the "rules clear?" part.

I think the current label is almost worthless as it is usually added without clarifying what needs clarification, so it is basically an encouragement to add more and more text to the issue trying to catch whatever is being unclear to whoever.

If a rule is not clear to everyone, the person that feels so should clarify exactly what needs to be clarified and then you can actually clarify the rule, so you need an intermediate thing between the "rules clear?" and "clarify rule" steps.

Moreover, the "clarify rule" step should direct back before the "rules clear?" step, because having clarified a rule doesn't imply that is actually fully clarified. So the clarify rule should direct to "update issue".

Moreover, I've no idea how an issue can be complete if it is not clear, but maybe you mean that just satisfies the minimal requirements of reporting. I think you should clarify what you mean by "complete".

frigoref

@cernel You are right this process flow is not detailed enough for what exactly to do in which situation. However, that was not the goal as this would limit the main goal of clarity of different parts and participants for the whole process.

Basically the Issue Dispatcher should check and provide labels based on which the other roles should take actions. For sure just a label is not enough and additional request/questions should be also added by him/her.

frigoref

May I ask for your help to create a profile for each of the following roles we have identified so far:

Developer with merge rights ( @RoiEX, @LaFayette )
Developer w/o merge rights ( @RaiNova, me )
Issue manager ( @beelee )
Map makers ( @RogerCooper )
Rule gurus ( @Panther )
Forum moderators ( @Cernel )

If someone would like to chip in, please feel free to come on board and assist.

My idea of a profile (that we could gather in a new profile folder in https://github.com/triplea-game/triplea/tree/master/docs would look as follows:

Title: Developer w/o merge rights
Description: Foot soldier who works on the code to fix bugs and add new features.
Skillset

Experience with object oriented programming language (preferable Java)
github account to contribute

Contributions

Bug fixing
Implementing new features
Code cleaning
Code review

How to become one: Setup your system and check our development processes

Before we start: What do you all think about this structure?

beelee

@frigoref you could have Panther and Cernel for rules. Cernel would qualify for maps as well and probably Panther too. My guess is new devs don't have merge rights is because it could mess stuff up if they went solo mode. My impression is you guys are all cool and probably wouldn't be a problem, but as i've said before I just update the maps and don't mess with anything else.

Idk, It's good to have a "structure" . It seems there already is one of sorts though ? Idk

Foot soldier seems a bit harsh : ) Reminds me of my buddy deploying when I asked him his job. "Bullet Stopper" was his response. Fortunately he made it back ok. Or not blown up anyway.

Edit
But yea it'd be fine by me. Didn't mean to sound overly negative or anything : )

frigoref

@beelee thanks for your feedback!
I take it you are okay to provide a profile in the structure suggested. Correct?

The participants you have suggested can now reply to the parts you say they'd be suited.

Last, the fine-tuning of the profile content I've suggested is maybe something for the PR process.

beelee

@frigoref heh heh yea Idk about issue dispatcher. I just try not to get too frustrated with git. I'm someone who only knows how to add but it's a multiplication problem lol

Sure the other guys will chime in. Been quiet here lately

Panther

@beelee Thank you

@frigoref For years (some more than a decade), these have been my playgrounds:

qualified answers to rules questions (core game rules)
engine testing
bug reporting
Github issue investigating, accepting or denying (when rules / gameplay related)
end user support for engine and map-related issues
end user support for software issues on the user's side
end user support for some core procedures on Github
end user support for some aspects of map creating and tweaking
forum administration (some special tasks)
forum moderation

In the past I have understood myself as being sort of an "interface" between development/developers and end user.

Not sure how that fits to any profile.

frigoref

@panther the profiles are kind of the facets a contributor can have and they should lead as guide for people who are willing to contribute to a point where they can actually do the contribution they want to.
It is very welcome if contributors as yourself match to multiple facets (=profiles).

At the moment my goal is to complete the list of profiles, get a common structure, get support to fill them out and finalize them in a group.
Would you be willing to take over the profile of a rules guru?

Panther

@frigoref said in TripleA development:

Would you be willing to take over the profile of a rules guru?

Yes, of course.

beelee

@frigoref heh heh "guru" just makes me chuckle

frigoref

Please have a look for my started contribution page, give feedback and fill the "tbd" parts according to our list:

Developer with merge rights ( @RoiEX, @LaFayette )
Developer w/o merge rights ( @RaiNova, me )
Issue manager ( @beelee )
Map makers ( @RogerCooper )
Rule gurus ( @Panther )
Forum moderators ( @Cernel )

beelee

@frigoref I guess for mapmaker you'd want an understanding of how xml works as well as graphically creating the map.

LaFayette

@frigoref

WDYT of adding a "$$ Funding" contributor role that links to our paypal?
What type of content will be behind the "player" contributor role link?

frigoref

@beelee
Can you help me please on the "graphically creating the map". A map maker should have a way to create image files for the map items like territories and units, i.e., a tool (like Photoshop) and the skill to design it in the tool?

PS: The link was an invitation to contribute on github directly

frigoref

@lafayette
Alright, I have added the role Donor.
For the question on the content behind the "player" contributor role link, I would ask you to try it: Player

Panther

@frigoref said in TripleA development:

PS: The link was an invitation to contribute on github directly

PR sent

frigoref

@panther thanks for you input.
Anyone else is also welcome!

TheDog

@frigoref
Maybe the Map Maker should be called Map Loader or Map Git Loader?
AFAIK @beelee and @ff03k64 could be added to the list of Map Loaders.

To me a Map Maker is alkexr, ebbe & Frostion they are not always the same as a Map Loader.

LaFayette

@frigoref

Missing Roles

Seemingly two missing two roles:

Map Admin: These people curate the maps and generally try to make sure that they work. They tag maps and check for them for quality and to the best of their ability trademark issues. They help out with updating XMLs as needed, helping to ensure that all maps are complete (have images) and generally play well.
QA: these people do extensive user testing of the game, typically on the prerelease and then submit high quality bug reports regarding their findings. They help doing regression tests before 'stable' releases are launched.

Terminology - Contributor Role vs Community Role vs Project Role

Having "Players" as a contributor role was seemingly a bit odd (or so I thought initially). Though, I see we basically ask Players to submit problem reports when they come across them. I would consider renaming the term: "contributor role" to "community role" or "project role" perhaps.

Alternatively, we can avoid labeling these roles and rename the header of the section to something like "How to contribute to Triplea"

beelee

@frigoref said in TripleA development:

@beelee
Can you help me please on the "graphically creating the map". A map maker should have a way to create image files for the map items like territories and units, i.e., a tool (like Photoshop) and the skill to design it in the tool?

Yea idk how to do the graphic stuff other than tweak a few existing units. Cernel and wc_sumpton can do both xml and graphics that are currently active here. A few others as well.

PS: The link was an invitation to contribute on github directly

ahh ...