Screen Won't Center on Capital at Turn Start with Tech Off

beelee

I don't use it

Edit
Hmm ... wonder what we could replace it with

Cernel

@wc_sumpton said in Screen Won't Center on Capital at Turn Start with Tech Off:

Thanks for the call out.

<!-- Germans Game Sequence -->
<!-- Dummy step used to insure map is centered for human player (first step is used to center) -->
<step name="germansNoPUEndTurn" delegate="endTurnNoPU" player="Germans"/>
<step name="germansTech" delegate="tech" player="Germans"/>
<step name="germansTechActivation" delegate="tech_activation" player="Germans"/>
<step name="germansPurchase" delegate="purchase" player="Germans"/>
<!-- Second purchase is used to give units per territory in case player loses all production capabilities -->
<step name="germansNoPUPurchase" delegate="purchaseNoPU" player="Germans"/>
<step name="germansPolitics" delegate="politics" player="Germans"/>
<step name="germansCombatMove" delegate="move" player="Germans"/>
<step name="germansAirborneCombatMove" delegate="specialCombatMove" player="Germans" display="Airborne Attack Move"/>
<step name="germansBattle" delegate="battle" player="Germans"/>
<step name="germansNonCombatMove" delegate="move" player="Germans" display="Non Combat Move"/>
<step name="germansPlace" delegate="place" player="Germans"/>
<step name="germansEndTurn" delegate="endTurn" player="Germans"/>

Used in UHD WIP 1940-45 (mega_new_elk)

Again, thank you @beelee

Cheers...

I would actually also argue that the fact that this hack works at all is a problem too (an unwanted behaviour). In my opinion, the visual should not be centred on "germansNoPUEndTurn" (ever) because that phase requires no actions from the player.

Cernel

@brazza said in Screen Won't Center on Capital at Turn Start with Tech Off:

@wc_sumpton
Oh thanks, I misunderstood.

Sure I should be able to fix it. I will take it once the issue is opened.

https://github.com/triplea-game/triplea/issues/13241

Brazza

@cernel
I see, I will start on it later.
Thanks for your trust!

beelee

@wc_sumpton

Another heads up when using this code, unfortunately, when playing by forum, it will ask if you want to post after the added endTurnNoPU step.

It will ask twice with the "are you sure" so it seems better to just one click on the mini map where you wanna go. Make for cleaner play and minimize any confusion.

Works great in local Idk if the new pre auto centers now or not. Haven't tried it yet

wc_sumpton

@beelee, @Cernel

Using 2.7.15129 there is no centering. Game's start with the map located in the upper left corner. So instead of 'tech' or 'endTurnNoPU' nothing centers on the current players capitol.

Is the desired effect?

Cheers...

beelee

@wc_sumpton

Hi wc

Is that latest pre ? I'm still using 14962 and it works correctly.

Panther

@wc_sumpton
The same with 2.7.15064 . So it must have been introduced between 14962 and 15064.

wc_sumpton

@panther, @beelee, @Cernel

As of 2.7.15152, this still has not been addressed. I left a comment on the, still active, request #13241 about 2 weeks ago. Should a new bug/problem be open?

Cheers...

beelee

@wc_sumpton

Oh ? I hadn't been following. I thought it had been addressed. Evidently not.

I'd suggest giving frigoref a ping at the issue. He's been active lately.
Maybe @Panther has more information than I.

Panther

@beelee @wc_sumpton No sorry, I don't have any further insights.

TheDog

Apparently with
https://github.com/triplea-game/triplea/releases/tag/2.7.15494

Centering on 1st Capital now works, but I cannot make it happen.

There are some criteria what are they?
View> Lock Map UNTICKED
and ...

wc_sumpton

@TheDog

We have come full circle. If the map contains skippable 'first' steps, technology, politics, and that 'first' is turned off the map will not center. The only way to ensure that the map centers is to create a 'first' step that cannot be turned off. This is the 'hack' that @beelee and I discussed using "endTurn/endTurnNoPU" which @cernel took issue with.

So, centering again works but only on the players 'first' step. If the 'first' step can be turned off, then centering does not work.

2.7.15494 did not fix the problem, it just reverted back to the 'old' problem.

Cheers...

beelee

@wc_sumpton

yea your xml hack worked for centering but I believe you had to double post when playing by Forum or something. I don't remember exactly what it was.

Cernel

@wc_sumpton said:

@TheDog

We have come full circle. If the map contains skippable 'first' steps, technology, politics, and that 'first' is turned off the map will not center. The only way to ensure that the map centers is to create a 'first' step that cannot be turned off. This is the 'hack' that @beelee and I discussed using "endTurn/endTurnNoPU" which @cernel took issue with.

I'm not against hacking per se. I think it should be fine doing it that way until a proper way is available. (I hack stuff too if I'm not seeing any better ways.)

Eventually though, the "endTurn/endTurnNoPU" should better become a step which never causes any centring in my opinion. If that happens, the map-maker who used the hack (which I think is fine) should better just update their maps (removing the now useless steps). No big deal: it's just a visual thing.

wc_sumpton

@Cernel said:

I'm not against hacking per se.

LoL. Just pointing out this discussion which changed 'centering', that got broken, then reverted back to 'first' step only.

Cheers...

TheDog

Is the solution to have centering pre the
MoveDelegate

So not pre Tech or Politics or EndofTurn or noPUEndTurn Delegate

Does pre the MoveDelegate work for most maps?

wc_sumpton

@TheDog said:

Does pre the MoveDelegate work for most maps?

I'm not understanding the question. Centering, as of 2.7.15494, happens on the 'first' delegate. If the 'first' delegate is skipped, then centering does not happen. 2.7.15025 centered on the 'first active', required players attention, delegate.

Almost any delegate can be used to 'hack' centering using 2.7.15494, but care and testing are necessary because some delegates do not fire the 'when' triggers if no action is taken. This is why I suggested "endTurn/endTurnNoPU" because these have internal cleanups and should always trip 'when'. And they are not 'prefect' because of these cleanups.
So, try different delegates and test to ensure the map functions as one expects.

Cheers...

TheDog

@wc_sumpton
With 300+ maps and a solution that requires no xml changes to work, could be using a pre Move Delegate centering, maybe?

wc_sumpton

@TheDog said:

With 300+ maps and a solution that requires no xml changes to work, could be using a pre Move Delegate centering, maybe?

Ahh, now I understand your question. Before I answer let's look at what is being asked. Using "World War II Global 1940 2nd Edition" with the default settings, technology is 'off' in 2.5.22294 the map does not center, which is the same as 2.7.15494. So, what we have now is the same as how TripleA has always function. Adding centering to the MovePhase would cause TripleA to reorientate during the players turn, which could be very confusing.
If the centering which is in 2.7.15025 cannot be duplicated, then IMO, centering should be left to map makers as an XML hack, and not added to a 'phase'.

Cheers...