@RogerCooper Another aspect to duplication of 'map.yaml' - when we fork the repo into 'triplea-maps', (we being the map admins), the map admins should check that 'map.yml' has been updated.

@RogerCooper If the map_name is duplicated, then we see the example we had with ww2v5 variants being downloaded instead of the correct map.

Note the table has an "ID" and "repo_url", those are both unique. The map-name does not have to be unique though. It should though..

The non-uniqueness of map-name is a design flaw baked in since TripleA was first written. The code treated the name of the map as its unique identity. Ideally the code would use the map IDs wholesale.

Prior to 2.6, the code would look for a map by name, searching for the a map folder with that name, then for an XML with a map_name attribute on it that also had to match. That's updated where the new code ignores the name of the map folder entirely, just looks at "map.yml" to do the matching of the map name. The "map.yml" then indicates where the game XML files are located. Thereby the code is able to load the XML files by using [map_name, game_name] by reading just the 'map.yml' file. Non-uniqueness of map names across all map.yml files is a design flaw.

@LaFayette Is https://github.com/triplea-game/triplea/blob/main/triplea_maps.yaml now deprecated?

What happens if map.yml is duplicated? Some people have work in progress on Github.

I don't much like triplea_maps.yaml but there needs to be some control over the mods.

I can confirm that it downloads fine now. That already was a good example for the workflow.
Thank you