Did a quick report on invalid maps, just one with invalid YAML that I found:
Invalid map.yml data found at URI: https://github.com/triplea-maps/1888a_steam_and_steel/blob/master/map.yml?raw=true, error: Invalid yaml format: mapping values are not allowed here
Second, the server needs to be updated to also check for a 'main' branch in the maps. That would fix a few more maps. (We should prefer "main" as our default branch name going forward rather than "master", fwiw. I'm a bit tempted to bulk update all maps to use 'main' as its default branch).
It does seem like there should be quite a few more maps though, even with those fixes applied. I'll need to investigate further to see why/where more maps are not being picked up.
If you tried to download one of these broken maps now, would there be an error.
In those cases the download button would be disabled. So, the map description area would be a place where the server would report the map problems, and no download button.
You may notice, some maps are missing their description.html file, the map download window indicates that file is missing in the description area (but still allows download). So, similar strategy for the maps are fully broken.
The alternative I was thinking was to have a dedicated website page with a big table of each map and its status. That might still be in the cards, but feels cleaner to have that info directly built into the game (and the map tag management I think should be there too rather than in the moderator toolbox).
I notice that there some maps which always a need to download such as Alexander 350BC. the mpa.yml file is
I believe that YAML snippet is fine. The "map_name" is the name of the download, it is the name of the download. After download, the "game name" is the thing that people select as what they want to play, and the "file_name" is a path to the XML file so that the game engine knows where the game data is physically located. FWIW, these values are all now explicit, before the game engine just assumed that the XML had a value that matched the map name, which would match the folder name of the map, etc.. Now none of those need to match, all the "index" information is read from the "map.yml" file. (Of course, to keep compatibility with 2.5 engines, the folder & map names do need to match, with 2.7 the structure and naming is more flexible and less important)