@beelee

Idk if you can change the display or not but POS2 just has "Turn Complete"

<delegate name="endTurnNoPU" javaClass="games.strategy.triplea.delegate.NoPUEndTurnDelegate" display="Turn Complete"/>

Doesn't have "...No PU" in it

I first tried it with "Turn Complete but it didnt work so it was something I changed to see if it did work.

However it seems that ive solved it now. I changed

<step name="bloodelvesEndTurnNoPU" delegate="endTurnNoPU" player="BloodElves"/> to <step name="bloodelvesEndTurn" delegate="endTurnNoPU" player="BloodElves"/>

And it seems to work now.
Seems weird to me that they have to have the same name even tho they are different things.

@beelee

The problem might be with the conditions/'when'. I think control of a territory after battle is not changed until 'endTurn' so checking 'after:japanCombat' will always be false. By removing the 'when' the trigger is checked at 'endTurn' and fires.

Cheers...

@hepps Right On ! That's Awesome ! Canada can give them to their Peacekeepers. Keep em safe at night 🙂

Thanks Rock On !!!.png

@numetalfan I would try using "unitPresence" and"directPresenceTerritories" instead . Something like

<option name="directPresenceTerritories" value="53 Sea Zone" count="1"/>

<option name="unitPresence" value="battleship" count="1"/>

@trevan ahh...I remember that now. Idk if they're related or not, but the cause in this case is different. The reason the error threw, was because I moved some units in edit into combat as an engine workaround.

When i went to retreat the air units, there was still an edited unit alive and it didn't know where it came from is my guess. I thought maybe I needed a withdraw step up by Purchase, CombatMove etc..

@beelee well I sent an arty and inf against 2 inf and it had 48% success rate. I sent 1 tank and 1 inf and it had 51% success. Both had same attack power.

I guess it's just not gonna pick that Guard unit until all the other supported units are dead. Bummer.

I can't really think of any way to hack around it. Even if I could make a trigger work somehow, doubtful, if a Guard and arty were present in same TTy, it would negate the first attachment and I could use a second one for Guards only, It'd negate all the battles with artillery. Unless I could specify each TTy.

As I said, I'm doubtful of that idea.

I've also discovered it happens specifically when rolling history backwards between the American Combat and Non-Combat phases. Don't know if that's important.

@general_zod Right on !

<attachment name="triggerAttachmentNormandyOriginallyNeutral" attachTo="Germans" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
<option name="conditions" value="NormandyOriginallyNeutral"/>
<option name="territories" value="Normandy Bordeaux"/>
<option name="territoryAttachmentName" value="TerritoryAttachment" count="territoryAttachment"/>
<option name="territoryProperty" value="originalOwner" count="Neutral_Allies"/>
<option name="uses" value="1"/>
<option name="when" value="after:changerCombatMove"/>
</attachment>

Thanks General 🙂

@torpedoa

Maybe by a trigger with uses = 5
the condition would be a unit in the country or in a sea zone next to it.

However this might cause fifo, first in first out, which means the first 5 units would be repaired.

For the next round you would need another trigger.

Not an ideal solution, but maybe one that works

@themaster42 Rename the folder with your mod. You'll need to rename the xml as well.

@Numetalfan

You are probably right. I was thinking collect income, which is done at endTurn.

Cheers...

@ebbe it's interesting i kinda like the way it is tho 😛

@Numetalfan

I am sorry for being unclear. The attachment name 'territoryEffectrussinawinter' may be causing the problem:

<!-- <attachment name="territoryEffectrussianwinter" attachTo="russian_winter" javaClass="TerritoryEffectAttachment" type="territoryEffect"> --> <attachment name="territoryEffectAttachment" attachTo="russian_winter" javaClass="games.strategy.triplea.attachments.TerritoryEffectAttachment" type="territoryEffect"> <option name="noBlitz" value="armour:mobile_artillery"/> <option name="combatOffenseEffect" value="armour" count="-1"/> </attachment>

You are creating an attachment for 'russian_winter'.

Cheers...

@lafayette I agree, an automated system would be better.

@TheDog
I use dice 6
Commanders add support +1 for 10-20 units
No terrain effects

I use max combat value at 4 for normal battle, then with 2 different/stacking support attachments, some units can reach 6 for combat, like Legionaries e.g. to represent the strongest units.

Here the list which i think about atm. I extended it again because i have a great variety of units.
(air values = ranged) (normal values = melee)

shortbowmen (2/3) (1/1) longbowmen (3/4) (1/1) light javelin infantry (2/2) (2/2) medium javelin infantry (1/1) (3/3) -> 2 HPs heavy javelin infantry (1/1) (4/4) -> 2HPs light spearmen (0/0) (2/3) heavy spearmen (0/0) (3/4) -> 2HPs horsearchers (2/3) (2/1) light javelin horsemen (3/2) (3/2) medium javelin horsemen (2/1) (3/2) -> 2HPs heavy horsemen (0/0) (4/3) -> 2HPs war chariots (4/3) (2/1) -> 2HPs war elephants (1/1) (4/3) -> 2HPs

All horses and chariots are 2 movement and can scramble. Elephants only move 1.

Eventually you can just take the list and change what you think would be proper values. And of course your rough cost values. Dont need to be super precise.

As you can see, i put horses, chariots and elephants as offensive powers, and bowmen and spearmen the defensive ones overall and there are a great number of 2HP units, because i have healer units.

Thanks for your thoughts

hilltype2y.png

Okej, managed to adapt the hills relief; personally I think better than the previous one, but still not completely satisfied..... anyway, back to coding; this is acceptable in the mean while....

No map maker should be relying on the engine to generate any of these files for them. That behavior will go away, it's only there so that players do not need to redownload maps.

These are not that many changes necessarily, but the explanation has been too complex.. Game notes, map.yml and description.html are the only new things.

@Schulz

Sorry, none that I am aware of. You can set the Player to AI with 'defaultType="AI"'. This can be selected by the player at the start of the game.

Cheers...

@torpedoa Nice solution though.