For me its boring killing everything on the map, as it comes to a point when I know I have won, but I want the map to tell me have 🙄

Economic Victory is probably the way to go.
If there is a total of 300pu on the map then my formula is 300 x 66% = 200pu.

For the losing side only having 33% of the pu there is usually no coming back.

In xml terms you will need;

<property name="Economic Victory" value="true" editable="true"> <boolean/> </property> <property name="Democrats Economic Victory" value="200" editable="true"> <number min="150" max="300"/> </property> <property name="Republicans Economic Victory" value="200" editable="true"> <number min="150" max="300"/> </property>

Testing Forum poster

Test summary from TripleA, engine version: 2.5.22294, time: 21:19:03
Savegame

Suggested updates to PoS2 for isAIPlayer:

In the "<!-- National Objectives and Condition Attachments -->" area, line 2939 between "switch" and "turns" (which should be updated to "rounds":

<!-- National Objectives and Condition Attachments --> <!-- ... switch values: "true" or "false" (default is true). This is just a simple on/off switch, which gives map makers some memory function for their conditions. isAIPlayers values: "true" or "false" check if player is AI controlled. rounds values: which rounds this will be checked on (example: value="1:4:6-8:11-+" means rounds 1,4,6,7,8,11, and all rounds after 11) ... -->

And then "conditionAttachment_Americans_Aid_UK" can be changed to reflect the usage:

<attachment name="conditionAttachment_Americans_Aid_UK" attachTo="Americans" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player"> <!-- is the Americans not AI controlled --> <option name="isAIPlayers" value="false"/> <!-- players can be added to check both Americans and British --> <!-- <option name="players" value="Americans:British"/> --> </attachment>

All I can think of---

Cheers...

@wc_sumpton

Thank you!

@thedog Thank you! I suspect the issue is that I have spaces in the names of my units.

@wc_sumpton Thank you !!!

I've settled on Age of Tribes approach. Very straight-forward.

Going to try this again. 😂

This time I have added testing for haveResources.

LOL

Cheers...

@sculpt @Cernel
Does the same thing happen in the latest 2.6 ?
https://github.com/triplea-game/triplea/releases

@ted-self Uploaded to Github, https://github.com/triplea-maps/War_of_the_Roses_Revamp

To minimize the requests to what I believe would be the marginally most important improvement here, I suggest at least adding a decimal to the Wins and Draw results (or using the permille instead of the percent).

Currently a 100% Win in the battle-calculator is anything from 99.5% to 100.0% Win, and being 99.9% sure to win a battle may be significantly different from being 99.5% sure of the same, but currently they are both given as 100%.

@mattbarnes Caribbean would mean you need to take the Yucatan so you can even take 2 of the 3 Cuban Territories which allow you to try threatening the US South East. you would have to do it fast though before US builds up its navy b/c they have a huge naval advantage. Austrians can go down in Central America and usually sweep it.

South America can be done once you go to Cuba and have the US pinned down to not be able to build a navy or once you take Yucatan. You go to Panama, or the Galapagos Islands (better choice) and take them. You move in position to then try to take Lima and reinforce it. If you can fight of a Martian Counter Attack, you basically build a factory to make gas and wipe out the remaining force or brute strength your way.

Pacific can be done if you go south and Island Hop to some remaining German Islands. You have to reinforce Solomon Islands or get lucky that Samoa isn't taken. On Turn 2 your bring your force there and you can begin your Island Hopping ... remember reinforcements take 2 turns (going back to Mexico and back) and the US will not be threatened as a result. You can however with great routing, slow down Nemo Pirate Expansion or screw the British in defending south pacific. you can move to the North the threaten Japan if you want as well

I just finished my last game so I would be free to do a rematch.

@cernel

Created the following:
Pull Request

Don't know if it will take.

Cheers...

@fabulous-ferret
The way it works is there’s the game engine logic (for all maps) and there’s the map files, so yes if one map has some feature, you can make any map can have that feature, by editing the map files (mainly the xml). You’d open up the two maps in a text editor and start copying stuff over.

Anyone can do it, but I don’t know how difficult the diplomacy option is to implement or how tech-y you are

@ted-self Read this https://docs.github.com/en/repositories/working-with-files/using-files/downloading-source-code-archives