Hi @andrewthree

This is from World War II Global 1940 2nd Edition

<attachment name="conditionAttachment_False" attachTo="Germans" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
<option name="switch" value="false"/>
</attachment>

This still a little confusing to me how it all works but basically the "conditionAttachmentFalse" acts as an on/off switch. It's attached to the "Germans" who go first, so I guess try attaching it to the first player in WAW for starters.

<attachment name="conditionAttachment_Mongolia_May_Change_To_Russians_Control_Switch" attachTo="Russians" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
<option name="conditions" value="conditionAttachment_Mongolia_Not_At_War_With_Allies"/>
<option name="switch" value="true"/>
</attachment>

I didn't list the condition for this one but "conditionAttachment_Mongolia_May_Change_To_Russians_Control_Switch" means if the Allies aren't at war with Mongolia it can be activated when it's conditions are met.

<attachment name="conditionAttachment_Russians_Conquer_Japanese_Territory_By_Mongolia" attachTo="Russians" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
<option name="battle" value="Russians:Japanese:any:currentRound:Manchuria:Jehol:Chahar:Suiyuyan:Kansu:Korea"/>
</attachment>

This does it a little different than what you have. "battle" means those territories just need to be attacked. Doesn't need to be conquered.

<attachment name="triggerAttachment_Russians_Conquer_Japanese_Territory_By_Mongolia" attachTo="Russians" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
<option name="conditions" value="conditionAttachment_Russians_Conquer_Japanese_Territory_By_Mongolia"/>
<option name="when" value="after:russiansBattle"/>
<option name="uses" value="1"/>
<option name="players" value="Russians"/>
<option name="playerAttachmentName" value="RulesAttachment" count="conditionAttachment_Mongolia_May_Change_To_Russians_Control_Switch"/>
<option name="playerProperty" value="switch" count="false"/>
</attachment>

This part is still a bit confusing as well for me but I think <option name="playerAttachmentName" value="RulesAttachment" activates the first switch "conditionAttachment_False" if conditionAttachment_Russians_Conquer_Japanese_Territory_By_Mongolia" is true.

<attachment name="triggerAttachment_Japanese_Conquer_Russians_Territory_By_Mongolia_2" attachTo="Japanese" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player"> <option name="conditions" value="conditionAttachment_False"/> <option name="when" value="before:japaneseNonCombatMove"/> <option name="uses" value="1"/> <option name="changeOwnership" value="Olgiy:Mongolians:Russians:true"/> <option name="changeOwnership" value="Dzavhan:Mongolians:Russians:true"/> <option name="changeOwnership" value="Tsagaan Olom:Mongolians:Russians:true"/> <option name="changeOwnership" value="Central Mongolia:Mongolians:Russians:true"/> <option name="changeOwnership" value="Buyant-Uhaa:Mongolians:Russians:true"/> <option name="changeOwnership" value="Ulaanbaatar:Mongolians:Russians:true"/> </attachment>

So now that "conditionAttachment_False" is activated, the trigger changes Ownership.

<attachment name="triggerAttachment_Japanese_Conquer_Russians_Territory_By_Mongolia_3" attachTo="Russians" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
<option name="conditions" value="conditionAttachment_Japanese_Conquer_Russians_Territory_By_Mongolia"/>
<option name="when" value="after:japaneseNonCombatMove"/>
<option name="uses" value="1"/>
<option name="removeUnits" value="Ulaanbaatar:infantry" count="1"/>
<option name="removeUnits" value="Buyant-Uhaa:infantry" count="2"/>
<option name="removeUnits" value="Olgiy:infantry" count="2"/>
<option name="removeUnits" value="Dzavhan:infantry" count="1"/>
<option name="placement" value="Ulaanbaatar:Russian_infantry" count="1"/>
<option name="placement" value="Buyant-Uhaa:Russian_infantry" count="2"/>
<option name="placement" value="Olgiy:Russian_infantry" count="2"/>
<option name="placement" value="Dzavhan:Russian_infantry" count="1"/>
</attachment>

And now they change units. Also you want to use "conditions" not "trigger" for <option name="trigger"

At any rate, what this all means is, if Mongolia is not at war with the Allies and Japan attacks one of the listed Territories, Mongolia will turn into Russian Territories and units.

Hope it's not oo confusing. I think I confused myself already 🙂

@beelee I saw it in a map from 1.8.

edit now that I am on my PC, it was war of the relic.

@Numetalfan Sweet !

polygon grabber solved the porblems - this problem is solved !

thx @all

@beelee That property name should probably be changed to something like "Use Multiple Combat Rolls for Best".

FWIW, being able to specify unit stats at the start of a game is something I've wanted to build in for some time. Having to do triggers to get the same effect is clearly a workaround, so I'm sorry you're having to go through that pain. Hopefully some time in 2021 this will be a built in feature.

@Jason-Green-Lowe said

The NullPointerException went away on its own. Don't know why, but I'll take it!

I like it when things fix themselves 🙂

@ff03k64 heh heh was just gonna say that I didn't think you could do both unit attachment and support in one trigger. But you figured out 🙂 Right on I like a success story 🙂

@beelee I didn't need a capital at all.

One challenge is having a mechanism to associate a game notes file with the game file. Having the two files with matching names and the notes file being suffixed with '-notes.html' might be easy enough. For example:

world_at_war.xml world_at_war-notes.html

@Panther the two HTML files are now updated to be MD, they'll render now.

@wc_sumpton I don't think that is the problem. I am basing this off of other maps that have fully functional user actions, and they don't have conditions in the activated triggers.

This text change is also the only thing that isn't working correctly in those triggers.

It seems like it is firing the trigger and making the change, and then calling the text to display, after it has changed it.

As i read what I am typing, it doesn't seem like it is as clear as it could be, so please ask questions if it isn't clear.

Ah, just saw the responses : )
The variable route would work, you are still duplicating the territory names, but at least it's more concise. 👍

Now for the last thing for these units. How can i place them in allied territories (assuming i have a rookie there)?

Hi Roger,

check

https://forums.triplea-game.org/topic/2066/new-production-unit-barracks

for this - I had the same topic before.

PR: https://github.com/triplea-game/triplea/pull/7651

DanVanAtta created this issue in triplea-game/triplea closed Update: Automatically infer game XML property 'types' #7651